Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-30 Thread Florian Festi
Closed #963 via 28b3704034a9c772959485a130b918f414da9796.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#event-3603597156___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-17 Thread Pavel Raiskup
> So for rpmbuild none are installed.

I don't see any practical reason to exit status 11 in such case.  That's why I 
filled this issue originally.

Since we aren't entirely consistent here, we should document that exit status 
11 might be result of the `--nodeps` option.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-660291559___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-17 Thread Michal Domonkos
> > no matter if all build requires are installed
> 
> because rpmbuild does not check them because `--nodeps` is specified :) So 
> for rpmbuild none are installed.

Which does not necessarily mean that they are *missing*. But yeah, we still 
return 11, to "signal" that the deps weren't checked and some *might* be 
missing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-660094472___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-15 Thread Igor Raits
> no matter if all build requires are installed

because rpmbuild does not check them because `--nodeps` is specified :) So for 
rpmbuild none are installed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-658698922___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-15 Thread Pavel Raiskup
> or missing build deps (11)

Yes, and we return 11 also when `--nodeps` is specified (no matter if all build 
requires are installed).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-658635546___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-14 Thread Michal Domonkos
Possibly related: https://github.com/rpm-software-management/rpm/issues/1304

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-658035631___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-14 Thread Michal Domonkos
Had a quick chat on IRC with @ffesti and he said it's actually just three 
outcomes that rpmbuild may return; success (0), error (1) or missing build deps 
(11), in which case adding all three into the man page would be worthwhile. 
I'll skim through the code to double-check and go ahead with that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-658034249___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-14 Thread Michal Domonkos
Actually looking closely at the `rpmbuild(8)` man page, it seems we don't 
specify any exit codes there at the moment. So I'm wondering if it really is 
worth documenting them for this particular use case (`-br --nodeps`) only.

There could be a separate section called `EXIT CODES` or similar where 
`RPMRC_MISSINGBUILDREQUIRES` (code 11) would be described, but it still feels a 
bit awkward to only have that and not the others.

@ffesti, do we have a plan to document exit codes across RPM at all?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#issuecomment-658001179___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint