I can't find any good reason. Case closed.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/55#issuecomment-187211753___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
I am inclined to reject this patch. The danger of missing patches unrecognised
outweighs the benefit of using a svn for applying the patches in my opinion.
Are there any use cases where using svn really gives a substantial improvement
over other tools?
---
Reply to this email directly or view
It can be applied also without support for compressed patches but it would be
nice at least to show some error and fail build when somebody will try to use
compressed patches with svn. Now no error is showed an build continues without
applying patches.
---
Reply to this email directly or view
Replacing `%__scm_apply_quilt(qp:m:)` according to
http://mywiki.wooledge.org/Bashism from
```
%{__quilt} import %{-p:-p%{-p*}} %{1} && %{__quilt} push %{-q}
```
to
```
mkfifo debbuild.fifo; cat >debbuild.fifo &\
%{__quilt} import %{-p:-p%{-p*}} -P %{-m*} debbuild.fifo && %{__quilt} push
%{-q}\
Another try with `<(cat)` instead of `%{1}`: Set **bash** as executing shell in
the specfile
```
%prep
%define _buildshell /bin/shell
%autosetup -S svn
```
This produces the correct commands
```
+ /bin/cat
/home/andreas/Programming/RPM/SOURCES/0001-Fix-intermediate-bugs.patch
+ /usr/bin/svn
I suggest to stick with `%{1}` (for both `%__scm_apply_svn` and
`%__scm_apply_quilt`) and go without compressed patches (well, `quilt` _does_
this internally).
---
Reply to this email directly or view it on GitHub:
@lkardos Thanks for the hint; that syntax was new to me. In a first attempt, it
indeed works from the console with `quilt` and `.zip`ped patches. However,
`<(cat)` seems to be **bash** syntax. Both **debbuild** and **rpmbuild** use
`#!/bin/sh` as the executing shell interpreter, which – at
Keyword "process substitution": http://mywiki.wooledge.org/Bashism
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/55#issuecomment-176393161___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
> @@ -1120,6 +1122,23 @@ done \
> %{__patch} %{-p:-p%{-p*}} %{-q:-s}\
> %{__bzr} commit %{-q} -m %{-m*}
>
> +# Subversion
> +%__scm_setup_svn(q)\
> +%{__svnadmin} create .svnrepos\
> +%{__svn} mkdir %{-q} -m "Create directory structure."
> file://`pwd`/.svnrepos/trunk\
> +%{__svn} checkout
Maybe instead of %{1} you can try <(cat) and maybe this will work also for
compressed patches but I didn't tried that, just an idea.
---
Reply to this email directly or view it on GitHub:
15 matches
Mail list logo
