Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread mikhailnov
OrderWithRequires(pre) would probably be better for the use case which is described in this PR, but OrderWithRequires without pre also worked. This is probably some undocumented behaviour in dependency resolution, probably it tries to install required packages before the package which requires

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
This is indeed not possible. The argument here is (except that it is simply not implemented) that those dependencies are generated from files in the package and not the scriptlets. So qualifiers should not be needed. But I am pretty sure people could come up with some valid use cases. There is

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread mikhailnov
Thanks. One question: do I understand correctly that currently there is no way to make a generator of Requires(pre), Requires(post), Requires(postun), OrderWithRequires(pre) etc.? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
Yes, not having a dependency generator for OrderWithRequires is clearly an oversight. Details on what generators are a valid use case are not relevant here. Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
Merged #1257 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1257#event-3424224260___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-08 Thread Zbigniew Jędrzejewski-Szmek
> But why? If a package contains a config is /usr/lib/sysusers.d/, why not to > ensure that it is installed after systemd-sysusers binary is present and so > the scriptlet which creates users can be executed? Yes, in that case the dependency is warranted. > If there is just a scriptlet which

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-07 Thread mikhailnov
If there is just a scriptlet which calls `systemctl preset`, in _some_ cases it may silently fail to enable a service which must be enabled. In most cases, I agree, it is not needed, but seems to be not harmful. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-07 Thread mikhailnov
But why? If a package contains a config is /usr/lib/sysusers.d/, why not to ensure that it is installed after systemd-sysusers binary is present and so the scriptlet which creates users can be executed? -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-07 Thread Zbigniew Jędrzejewski-Szmek
> it is only some specific cases where this needs to be used. Yeah, we used to pull in systemd much more often. Nowadays, most packages should not pull in systemd, and install time ordering also doesn't matter. But that's largely irrelevant here, since systemd was only used as an example here.

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-07 Thread Igor Raits
> When a package contains a systemd unit, %systemd_* macros are usually used; > it is usefull to add "OrderWithRequires: systemd" in this case to ensure > that systemd is installed before that package. I think I disagree here, it is only some specific cases where this needs to be used. cc

[Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-06 Thread mikhailnov
It was possible to generate Requires, Recommends etc. using external dependency generators. Adding ability to generate OrderWithRequires. Example use case: When a package contains a systemd unit, %systemd_* macros are usually used; it is usefull to add OrderWithRequires: systemd in this case to