Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-08-19 Thread Panu Matilainen
@pmatilai requested changes on this pull request.

See above.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#pullrequestreview-470197533___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-10 Thread Panu Matilainen
Yeah this needs to interact with both _with_check and _without_check, and not 
add semantics to %_without_check value. And for that, it'd seem that we need to 
parse the spec before fiddling with these values as otherwise we can't know 
about bcond's set in the spec.
It also needs a better commit summary regardless of implementation, this is not 
about some macro being added but integration between --with/without check idiom 
and --nocheck.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-641884348___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread torsava
> I think this should set _with_check unless _without_check is defined already. 
> Basically to have `%bcond_without check` by default without having to put it 
> in all spec files. But still need to make sure that somebody defines 
> `%bcond_without check`, this code won't override it.

That would be absolutely perfect, if there's a way to do it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640515842___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread torsava
I would like to avoid `nocheck`, because the common way to conditinalize would 
be `%if %{without nocheck}` and that's just confusing to read.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640514577___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread Florian Festi
May be the macro should be renamed to not collide with the with/without 
mechanism. The bcond mechnism assumes that the actual value is not set as a 
macro but only on the command line and is basically read only within the spec. 
If you set the macro itself having two of them can lead to the awkward 
situation where but are set to one or both are set to zero. So I would prefere 
to only have one macro.
May be _nocheck is a better name and closer resembling the cli param. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640421215___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-07 Thread Igor Raits
I think this should set _with_check unless _without_check is defined already. 
Basically to have `%bcond_without check` by default without having to put it in 
all spec files. But still need to make sure that somebody defines 
`%bcond_without check`, this code won't override it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640229941___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-05 Thread Florian Festi
signaling and controling whether %check is executed during build.
The macro can be set globally or in the spec file. The --nocheck
parameter of rpmbuild takes precedence, though. If --nocheck is
passed to rpmbuild the macro set accordingly. Otherwise it is set
to 0 if not defined previously.

Resolves: #316
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1256

-- Commit Summary --

  * Add _without_check macro

-- File Changes --

M build/build.c (1)
M rpmbuild.c (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1256.patch
https://github.com/rpm-software-management/rpm/pull/1256.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint