Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. 2174e5386a289355201aa60c43d767d1e244a3ab Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48..2174e5386a289355201aa60c43d767d1e244a3ab ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. 4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48 Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/278fec730baf775462391e74f71057c8eb8128ec..4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. 278fec730baf775462391e74f71057c8eb8128ec Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/4aaacf8e0c7831d5f91054554c87c4473431afa0..278fec730baf775462391e74f71057c8eb8128ec ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. f7fd783f8146f1e151296ba3659355dcb9943bcb Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/090ad798d700b4f166f19ec55e8120e0716e606d..f7fd783f8146f1e151296ba3659355dcb9943bcb ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. 090ad798d700b4f166f19ec55e8120e0716e606d Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8..090ad798d700b4f166f19ec55e8120e0716e606d ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
OK, but there is an argument to be made that this should also work for just opening an rpm package without looking at the payload and instead just accessing the header. Which makes me wonder if we really need this to be context manager. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661799300___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
> We should also consider _what_ the high level interface should offer. Well, that's not what this PR is about. This "only" is about making it easier to open an rpm package from disk and reading the payload. We don't really plan to offer a new API for all other functionality. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661795382___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
We should also consider _what_ the high level interface should offer. From my perspective, it should (at the minimum) provide ways to: * Work with macros and spec files * Read RPM files * Orchestrate building RPMs * Do simple package management actions But to do this well, we need a design of how this would look... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661793990___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
I really like the idea of offering some easier to use API and using an context manager for that. But there are several aspects of this implementation that don't quite feel right to me. At first I wonder if we can find a better name for the class. This actually wraps (binary) packages. Not sure if `Package` is too generic but it is much closer to the truth. Abbreviating `archive` with `arch` is super confusing as `arch` is used everywhere else as synonym of `architecture`. The fd used should really be stay hidden inside the class. Using it else where will only lead to tears and broken bones. Not sure if `iterFiles` is really needed or if it is better to point to directly using the .archive attribute in the doc string. Or may be I am missing something here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661792867___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8 Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/8082ede9cc7222686f8466440b0d4c3df62fb45c..b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@pmatilai @Conan-Kudo @ignatenkobrain -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-657635032___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1311 -- Commit Summary -- * Added a high-level wrapper. -- File Changes -- A python/rpm/highLevel.py (38) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1311.patch https://github.com/rpm-software-management/rpm/pull/1311.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
