Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[soig]

Le mer. 24 juin 2020 à 08:38, Panu Matilainen  a
écrit :

> On 6/24/20 9:30 AM, soig wrote:
> > Also rpm's own fontconfig.prov is broken:
> >
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log
> >
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luigiwalser.duvel.10411/log/feh-3.4.1-1.mga8/build.0.20200623223403.log
> > disabling /usr/lib/rpm/fileattrs/font.attr makes the issue go away
> >
>
> Please open separate tickets for such findings, comments on past commits
> will easily go unseen and/or forgotten.
>
> - Panu -
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
>
Done
https://github.com/rpm-software-management/rpm/issues/1285
https://github.com/rpm-software-management/rpm/issues/1284


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648624913___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Panu Matilainen]

On 6/23/20 5:16 PM, rpm-maint wrote:
> Architecture is hardcoded in test and thus it fails on anything not x86_64
> :-(
> 
> See
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log
> 
> --- - 2020-06-23 13:59:13.826080861 +
> +++ 
> /home/iurt/rpmbuild/BUILD/rpm-4.16.0-beta2/tests/rpmtests.dir/at-groups/329/stderr
>  
> 2020-06-23
> 13:59:13.811945165 +
> @@ -1,3 +1,3 @@
> -error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> - Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> +error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
> + Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang

Doh, what a stupid issue, thanks for reporting. Fixed in
https://github.com/rpm-software-management/rpm/pull/1283, but *please* 
open tickets for such findings. Emails and comments to old PRs/commits 
lack proper tracking, and get all too easily lost in the noise to begin 
with.

- Panu -



-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648624812___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Panu Matilainen]

On 6/24/20 9:30 AM, soig wrote:
> Also rpm's own fontconfig.prov is broken:
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luigiwalser.duvel.10411/log/feh-3.4.1-1.mga8/build.0.20200623223403.log
> disabling /usr/lib/rpm/fileattrs/font.attr makes the issue go away
> 

Please open separate tickets for such findings, comments on past commits 
will easily go unseen and/or forgotten.

- Panu -



-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648623641___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[soig]

Ex:

$ sudo mv /usr/lib/rpm/fileattrs/font.attr{,.no}
$ LC_ALL=C rpmbuild --short-circuit --define "_topdir $PWD" -ba
SPECS/feh.spec
(…)
Wrote: /home/tv/mga/pkgs/feh/RPMS/x86_64/feh-3.4.1-1.mga8.x86_64.rpm
Wrote:
/home/tv/mga/pkgs/feh/RPMS/x86_64/feh-debugsource-3.4.1-1.mga8.x86_64.rpm
Wrote:
/home/tv/mga/pkgs/feh/RPMS/x86_64/feh-debuginfo-3.4.1-1.mga8.x86_64.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.3qCi65
+ umask 022
+ cd /home/tv/mga/pkgs/feh/BUILD
+ cd feh-3.4.1
+ /usr/bin/rm -rf /home/tv/mga/pkgs/feh/BUILDROOT/feh-3.4.1-1.mga8.x86_64
+ RPM_EC=0
++ jobs -p
+ exit 0

$ sudo mv /usr/lib/rpm/fileattrs/font.attr{.no,}
$ LC_ALL=C rpmbuild --short-circuit --define "_topdir $PWD" -ba
SPECS/feh.spec
(…)
error: Requirename generator   failed:
/home/tv/mga/pkgs/feh/BUILDROOT/feh-3.4.1-1.mga8.x86_64/usr/share/feh/fonts/yudit.ttf
Provides: application() application(feh.desktop) feh = 3.4.1-1.mga8
feh(x86-64) = 3.4.1-1.mga8 mimehandler(image/bmp) mimehandler(image/gif)
mimehandler(image/jpeg) mimehandler(image/jpg) mimehandler(image/pjpeg)
mimehandler(image/png) mimehandler(image/tiff) mimehandler(image/webp)
mimehandler(image/x-bmp) mimehandler(image/x-pcx) mimehandler(image/x-png)
mimehandler(image/x-portable-anymap) mimehandler(image/x-portable-bitmap)
mimehandler(image/x-portable-graymap) mimehandler(image/x-portable-pixmap)
mimehandler(image/x-tga) mimehandler(image/x-xbitmap)
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: libImlib2.so.1()(64bit) libX11.so.6()(64bit)
libXinerama.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.11)(64bit)
libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.15)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.7)(64bit) libcurl.so.4()(64bit) libexif.so.12()(64bit)
libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpng16.so.16()(64bit)
libpng16.so.16(PNG16_0)(64bit)
Recommends: imagemagick jpeg-progs


RPM build errors:
Requirename generator   failed:
/home/tv/mga/pkgs/feh/BUILDROOT/feh-3.4.1-1.mga8.x86_64/usr/share/feh/fonts/yudit.ttf


Which is strange as fontconfig.prov returns 0…


Le mer. 24 juin 2020 à 08:29, Thierry Vignaud  a
écrit :

> Also rpm's own fontconfig.prov is broken:
>
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log
>
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luigiwalser.duvel.10411/log/feh-3.4.1-1.mga8/build.0.20200623223403.log
> disabling /usr/lib/rpm/fileattrs/font.attr makes the issue go away
>
> Le mar. 23 juin 2020 à 16:16, rpm-maint  a
> écrit :
>
>> Architecture is hardcoded in test and thus it fails on anything not x86_64
>> :-(
>>
>> See
>>
>> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log
>>
>> --- - 2020-06-23 13:59:13.826080861 +
>> +++
>> /home/iurt/rpmbuild/BUILD/rpm-4.16.0-beta2/tests/rpmtests.dir/at-groups/329/stderr
>> 2020-06-23
>> 13:59:13.811945165 +
>> @@ -1,3 +1,3 @@
>> -error: Requirename generator /tmp/fail.req failed:
>> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
>> - Requirename generator /tmp/fail.req failed:
>> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
>> +error: Requirename generator /tmp/fail.req failed:
>> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
>> + Requirename generator /tmp/fail.req failed:
>> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
>>
>> 329. rpmbuild.at:482: 329. Dependency generation 3 (rpmbuild.at:482):
>> FAILED (rpmbuild.at:505)
>>
>>
>> Le mar. 23 juin 2020 à 12:01, Panu Matilainen 
>> a
>> écrit :
>>
>> > Merged #1271 
>> > into master.
>> >
>> > —
>> > You are receiving this because you are subscribed to this thread.
>> > Reply to this email directly, view it on GitHub
>> > <
>> https://github.com/rpm-software-management/rpm/pull/1271#event-3472161361
>> >,
>> > or unsubscribe
>> > <
>> https://github.com/notifications/unsubscribe-auth/ADLPZU6TKOLLFK7O32BLNDLRYB4QTANCNFSM4OAPN7RQ
>> >
>> > .
>> > ___
>> > Rpm-maint mailing list
>> > Rpm-maint@lists.rpm.org
>> > http://lists.rpm.org/mailman/listinfo/rpm-maint
>> >
>>
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> ,
>> or unsubscribe
>> 
>> .
>>
>


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[soig]

Also rpm's own fontconfig.prov is broken:
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luigiwalser.duvel.10411/log/feh-3.4.1-1.mga8/build.0.20200623223403.log
disabling /usr/lib/rpm/fileattrs/font.attr makes the issue go away

Le mar. 23 juin 2020 à 16:16, rpm-maint  a écrit :

> Architecture is hardcoded in test and thus it fails on anything not x86_64
> :-(
>
> See
>
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log
>
> --- - 2020-06-23 13:59:13.826080861 +
> +++
> /home/iurt/rpmbuild/BUILD/rpm-4.16.0-beta2/tests/rpmtests.dir/at-groups/329/stderr
> 2020-06-23
> 13:59:13.811945165 +
> @@ -1,3 +1,3 @@
> -error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> - Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> +error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
> + Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
>
> 329. rpmbuild.at:482: 329. Dependency generation 3 (rpmbuild.at:482):
> FAILED (rpmbuild.at:505)
>
>
> Le mar. 23 juin 2020 à 12:01, Panu Matilainen  a
> écrit :
>
> > Merged #1271 
> > into master.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/rpm-software-management/rpm/pull/1271#event-3472161361
> >,
> > or unsubscribe
> > <
> https://github.com/notifications/unsubscribe-auth/ADLPZU6TKOLLFK7O32BLNDLRYB4QTANCNFSM4OAPN7RQ
> >
> > .
> > ___
> > Rpm-maint mailing list
> > Rpm-maint@lists.rpm.org
> > http://lists.rpm.org/mailman/listinfo/rpm-maint
> >
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
>


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648620251___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Panu Matilainen]

Merged #1271 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#event-3472161361___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[ニール・ゴンパ]

@Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#pullrequestreview-432885992___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Igor Raits]

:tada: 

Would be nice to get that into 4.16.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-645323467___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Panu Matilainen]

Previously only the legacy external dependency generator listened to
exit codes from the generator, and even that only for provides.
Anybody building packages will want to know if generators barf up
for one reason or another. Let them.

Always call rpmfcExec() with failnonzero set, pass errors around, add tests.

Fixes: #1183
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1271

-- Commit Summary --

  * Always fail build on dependency generator failures (#1183)

-- File Changes --

M build/rpmfc.c (32)
M tests/rpmbuild.at (36)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1271.patch
https://github.com/rpm-software-management/rpm/pull/1271.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint