Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-18 Thread Panu Matilainen
Sure, no worries. Things are a bit chaotic everywhere...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#issuecomment-600454258___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-17 Thread Michael Schroeder
Sorry, I haven't had time to have a closer look at this. Things are a bit 
chaotic here at SUSE with everything being locked down because of the corona 
virus.

But from my glancing over the changes everything looked fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#issuecomment-56556___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-17 Thread Panu Matilainen
Need to move on with this now...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#issuecomment-599922644___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-17 Thread Panu Matilainen
Merged #1119 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#event-3136165415___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-13 Thread ニール・ゴンパ
Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#pullrequestreview-374514672___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-13 Thread ニール・ゴンパ
Erk, oops, disregard that... I clicked the wrong thing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#issuecomment-598851749___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-12 Thread Panu Matilainen
In some scenarios we previously only created some of the indexes only
lazy db init through query. Partially initialized databases dont make
sense and are only asking for trouble, in particular this was causing
issues with sqlite backend which is stricter about readonly-mode.

Except for the special case of reading a potentially damaged database
for rebuilding, always open all the indexes from openDatabase().
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1119

-- Commit Summary --

  * Always open (and initialize) the entire database at once

-- File Changes --

M lib/rpmdb.c (37)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1119.patch
https://github.com/rpm-software-management/rpm/pull/1119.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint