@pmatilai does this revised version look good?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1492#issuecomment-768385550___
@DemiMarie pushed 1 commit.
3ce3e85d61caae81d94afcff6afa5046bc2d5f65 Use int64_t for lengths
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
"int" is (at least) 32 bits on all platforms rpm supports, that's not an issue.
The rough idea is that explicitly sized types are used for "physical" data of
that size, and abstract types for abstractions, such as results of calculation.
In fact this (and various other similar places) would
@DemiMarie pushed 1 commit.
8f0c8600f1bc25dd9b724ee4d4086fc0bf91827c Check that count and data length are
reasonable
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@DemiMarie pushed 1 commit.
fc4d264682aa89bcd61a941a4e328eb2c0df59f3 Check that count and data length are
reasonable
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
The added check may well be right, but it hardly prevents "any possible
overflow" there could ever be.
If you look at past commits, we go to great lengths to explain in which
situation some problem can happen and how the existing checks are not suffient,
please help keep the tradition. It
This avoids any possible integer overflows.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1492
-- Commit Summary --
* Check that count and data length are reasonable
-- File Changes --
M lib/header.c (3)
-- Patch
