Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Merged #1068 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1068#event-3038286887___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
pmatilai approved this pull request. Cool, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Michael Schroeder
@mlschroe pushed 1 commit. 3252e1e25872bc7820828425e1daea51d0700b13 Remove duplicated code in fpLookupSubdir -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Ouch, no. Sorry. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586170405___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Reopened #1068. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1068#event-3037996933___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Igor Gnatenko
@pmatilai was it intentional to close PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586161085___

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Closed #1068. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1068#event-3037849435___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Nice. Since you're fixing the cicle/cycle comment typo already: care to fix that entire comment while we're at it? These patches get rid of all the other // comments in there, so that one out-of-style sticks out even more now. Plus it could be more concise, really. Not that this is a

[Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-13 Thread Michael Schroeder
Simplify the way the fingerprint cache is created. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1068 -- Commit Summary -- * Move fingerprint hash setting out of fpLookupSubdir() * Remove duplicated code in