Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread frenzymadness
This is definitely something we want to fix in Python in the future. The biggest problem here is that marshal (the format used internally for byte-compiled cache files) has to be very fast and every step towards reproducibility has an impact of its speed. Moreover, I don't know if anybody

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329463___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Merged #1320 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1320#event-3603542624___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
In general I am not a fan of hiding issues this way and would prefer such issues would be found and fixed. Otoh we are so far away from Python upstream that this may just be the pragmatic thing to do. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-27 Thread frenzymadness
PR description is now included in the commit message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-24 Thread Miro Hrončok
As always, I suggest to put the description to the commit message, not just the PR description. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-24 Thread Miro Hrončok
@hroncok approved this pull request. I've already approved this in Fedora and I've asked @frenzymadness to bring it here as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-24 Thread Igor Raits
@hroncok -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-663508390___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-24 Thread frenzymadness
Sometimes, byte-compilation might produce two functionally identical pyc files that are not byte-to-byte identical which might cause problems. Disabled hash seed randomization does not solve this problem entirely but helps a lot by lowering probability. You can view, comment on, or merge this