Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
Merged #1318 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#event-3603597053___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
Thanks for all the work and polishing! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#issuecomment-666335786___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@ffesti approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-458353180___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-457471065___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks pushed 1 commit. c9b9a299d93ead98e1f05098b3f80d46f8813153 Docs: Add DYNAMIC BUILD DEPENDENCIES section -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318/files/6c358561b2b7593c9717797305d96d4133140ba6..c9b9a299d93ead98e1f05098b3f80d46f8813153 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > +to run this command (followed by new dependency resolution) repeatedly until > it +no longer exits with code 11. New revision force-pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459976548___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > +to run this command (followed by new dependency resolution) repeatedly until > it +no longer exits with code 11. OK, thinking about it more, a situation could arise where a missing dep can't be resolved or installed (with `dnf builddep`) for whatever reason, in which case saying that "repeat the whole `rpmbuild -br` + `dnf builddep` process while exit code = 11" would make this into an endless loop :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459961523___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > +to run this command (followed by new dependency resolution) repeatedly until > it +no longer exits with code 11. Yeah, "new dependency resolution" sounds a bit awkward and isn't exactly clear. Will fix. As for the "until" clause, I wonder if rpmbuild can exit with 0 and still generate new deps? From what I can see in the code, this shouldn't ever happen. I know that Mock actually does check for new deps (instead of the return code), but that's because they have to use `--nodeps` (due to unrelated reasons) which always returns 11. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459927495___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@ignatenkobrain commented on this pull request. > +to run this command (followed by new dependency resolution) repeatedly until > it +no longer exits with code 11. ```suggestion to run this command (followed by installation of the generated dependencies) repeatedly until no new dependencies are generated. ``` Probably something like this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-454722041___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks pushed 1 commit. 6c358561b2b7593c9717797305d96d4133140ba6 Docs: Add note on buildreqs.nosrc.rpm and code 11 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318/files/96bf7343c84bf463baf7eb0f40a617c9019dd74f..6c358561b2b7593c9717797305d96d4133140ba6 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks pushed 1 commit. 96bf7343c84bf463baf7eb0f40a617c9019dd74f Docs: Add note on buildreqs.nosrc.rpm and code 11 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318/files/4524a18507fa3b13052ab3ae180c319aff8c4fc6..96bf7343c84bf463baf7eb0f40a617c9019dd74f ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. Reworded, please let me know if it's better now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459551390___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. Ah, I see. The [dummy spec](https://github.com/rpm-software-management/rpm/files/3911787/dummy-pkg.spec.txt) that @hrnciar provided in the related issue actually does exactly that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459327199___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@ignatenkobrain commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. yes, that section is executed during each built, so if it has some check `test -x /usr/bin/foo ...`, then once foo will be available, it might generate new set of requires. that's why mock does `rpmbuild -br` + `dnf builddep` until it stops generating any new dependencies. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459325559___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. @ignatenkobrain, just to clarify, is that because of the fact that a `%generate_buildrequires` macro could be generated during the previous iteration? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459324461___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@dmnks commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. Oh, right. Thanks! I'll fix that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#discussion_r459320805___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
@ignatenkobrain commented on this pull request. > @@ -256,6 +266,18 @@ options are currently set in \fIrpmrc\fR and \fImacros\fR configuration file(s). +.SS "DYNAMIC BUILD REQUIREMENTS" +.PP +When the %generate_buildrequires stage is executed and some of the resulting +requirements are not satisfied, \fBrpmbuild\fR exits with code 11 and does not +create the source package. +Instead, a package ending with \fIbuildreqs.nosrc.rpm\fR is created, which has +all the build requirements, including the newly generated ones. This is not fully correct. It has `all the build requirements that were possible to generate at that point of time`, we need to point out for people that sometimes they will need to run `-br`, install deps and then run `-br` again and it might generate new dependencies. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-453961504___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1318 -- Commit Summary -- * Docs: Revamp BUILD OPTIONS section in rpmbuild(8) * Docs: Add note on buildreqs.nosrc.rpm and code 11 -- File Changes -- M doc/rpmbuild.8 (60) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1318.patch https://github.com/rpm-software-management/rpm/pull/1318.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
