Re: [Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-10 Thread Panu Matilainen
Merged #1258 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258#event-3428535250___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-10 Thread Panu Matilainen
Oh, somebody is actually using this functionality :sweat_smile: Always useful 
to know.

Thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258#issuecomment-641847640___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-09 Thread Florian Festi
Looks good to me. Should probably also go into 4.16.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258#issuecomment-641198193___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-07 Thread mikhailnov
If %_nonzero_exit_pkgcheck_terminate_build is true, then the build fails, 
otherwise it does not. This regressed and the build never failed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258#issuecomment-640224570___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-07 Thread mikhailnov
RPM build did not fail if rpmlint (%_build_pkgcheck_set) failed when checking 
binary RPMs
(it did fail correctly when rpmlint failed when checking SRPMs)

Probably fixes regression introduced by 78f61f273 (Refactor package set 
checking out of packageBinaries())
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1258

-- Commit Summary --

  * Fail the build if %_build_pkgcheck_set failed

-- File Changes --

M build/pack.c (7)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1258.patch
https://github.com/rpm-software-management/rpm/pull/1258.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint