Re: [Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)

2020-06-23 Thread Panu Matilainen
Merged #1279 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1279#event-3472164907___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)

2020-06-23 Thread Panu Matilainen
The existing FSM code doesnt correctly handle FA_TOUCH on hardlinked
file sets, which causes the hardlink set to break on at least some
upgrade scenarios when minimize_writes is enabled.

Only enable FA_TOUCH on non-hardlinked files to work around the issue
for now. While at it, rearrange the conditionals around min_writes to make
it a bit clearer. Testcase adopted from original reproducer by
Fabian Vogt, thanks!

Fixes: #1278
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1279

-- Commit Summary --

  * Fix (work around) FA_TOUCH not scoping correctly over hardlinks

-- File Changes --

M lib/transaction.c (17)
M tests/Makefile.am (1)
A tests/data/SPECS/hlbreak.spec (22)
M tests/rpmverify.at (24)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1279.patch
https://github.com/rpm-software-management/rpm/pull/1279.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1279
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint