Re: [Rpm-maint] [rpm-software-management/rpm] Fix ambiguous diagnostics output on file triggers (RhBug:1883338) (#1376)

2020-10-01 Thread Panu Matilainen
Merged #1376 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1376#event-3827802262___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix ambiguous diagnostics output on file triggers (RhBug:1883338) (#1376)

2020-09-30 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1376#pullrequestreview-499577267___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fix ambiguous diagnostics output on file triggers (RhBug:1883338) (#1376)

2020-09-28 Thread Panu Matilainen
All this time weve been logging file and transfile triggers with output
identical to that of regular triggers, confusing people for no good reason.

We know which of the three it is when creating so add a matching prefix
to the output at that point. All we need to do is move the % from
the scriptlet table to the printf() format string to make room for
the description prefix. Doh.

So now we get output using things with their proper names, such as:

  D: running post-transaction scripts
  D: %transfiletriggerin(glibc-common-2.31-4.fc32.x86_64): scriptlet start
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1376

-- Commit Summary --

  * Fix ambiguous diagnostics output on file triggers (RhBug:1883338)

-- File Changes --

M lib/rpmscript.c (34)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1376.patch
https://github.com/rpm-software-management/rpm/pull/1376.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1376
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint