Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Merged #1265 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265#event-3428649150___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Looks good. In my mind the prefix search is also bound to the index iteration. 
Probably because this is how it was introduced on bdb.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265#issuecomment-641862934___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Igor Raits
Seems to fix my problem :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265#issuecomment-641855601___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Panu Matilainen
The prefix search was so wrong its a small miracle it ever did anything
at all. What have I been thinking? Well, I do remember thinking this
prefix stuff looks kinda fishy but then it seems to work so...

The prefix search belongs to the keyed iterator fetch case of course,
not the case where were otherwise iterating over all keys.

Fixes: #1260
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1265

-- Commit Summary --

  * Fix completely broken prefix search on sqlite backend

-- File Changes --

M lib/backend/sqlite.c (51)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1265.patch
https://github.com/rpm-software-management/rpm/pull/1265.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint