Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-22 Thread Panu Matilainen
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-647424064___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-22 Thread Panu Matilainen
Merged #1264 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1264#event-3467630072___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-22 Thread ニール・ゴンパ
This patch is now running in OpenMandriva Cooker and seems to be working okay so far... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-18 Thread Panu Matilainen
If you don't mind... yeah, please do :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-645818174___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-17 Thread Tom Stellard
@pmatilai Do you want me to re-submit this pull request with your suggested fix? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-15 Thread Tom Stellard
> Okay, the problem is fairly obvious, pkg being declared way outside the > parallel block. > But rather than sprinkling more OpenMP magic dust to solve it, can you verify > that this (ie just declare the variable inside the parallel block) solves the > problem? > > ``` > #pragma omp

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-15 Thread Panu Matilainen
Okay, the problem is fairly obvious, pkg being declared way outside the parallel block. But rather than sprinkling more OpenMP magic dust to solve it, can you verify that this (ie just declare the variable inside the parallel block) solves the problem? ``` #pragma omp parallel #pragma

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-09 Thread ニール・ゴンパ
@ffesti I'd appreciate this being pulled into rpm-4.16 since this is going to be needed for OpenMandriva. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-09 Thread Tom Stellard
The pkg variable used in the parallel loop was declared outside of the omp parallel construct, so it was shared among tasks. This had the potential to cause a data race. The gcc openmp implementation did not hit this problem, but I uncovered it while trying to compile with clang. My best guess