Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
I don't see any need for further discussion here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-656689650___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
Merged #1272 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#event-3534004891___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
I guess given that the magic stuff hasn't worked in forever, it's fine to just drop it and not worry about it flaking in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Miro Hrončok
> To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an > intersection? That's actually somewhat surprising behavior... Union by default but can be switched with `magic_and_path` flag in `%__foo_flags` to intersection. -- You are receiving this because you are subscribed

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
@pmatilai To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an intersection? That's actually somewhat surprising behavior... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#pullrequestreview-437395755___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread torsava
The change looks good to me. And we've been using this in RHEL for a while with good results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Miro Hrončok
Ack. I'll ping people. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649284471___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Panu Matilainen
I was kinda expecting others from the Python camp to evaluate, I'm out of loop with what's going on in this land these days. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-24 Thread Miro Hrončok
Is this good to be merged? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649113390___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-18 Thread Miro Hrončok
Commit message amended. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-645958035___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-18 Thread Miro Hrončok
Indeed! This makes much more sense now, thanks. I'll amend the commit message. Before (file-5.38-6.fc33): ``` sh-5.0# file -z -e tokens /opt/usr/lib/python3.8/site-packages/{__pycache__/,}file* /opt/usr/lib/python3.8/site-packages/__pycache__/file.cpython-38.opt-1.pyc: data

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-18 Thread Miro Hrončok
> sounds more like a libmagic change than rpm one. Let me test that actually. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-18 Thread Panu Matilainen
I'm having some trouble parsing the description of what happened. But if files suddenly getting classified as python based on magic where they were not before sounds more like a libmagic change than rpm one. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-17 Thread Miro Hrončok
Downstream discovery in https://src.fedoraproject.org/rpms/python-rpm-generators/pull-request/20 I wonder, what changed in RPM? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-17 Thread Miro Hrončok
The %__python_magic filter suddenly got suppressed by the magic filter. Hence, the generator started to pick files like: /opt/usr/lib/python3.X/... Required python(abi). We dont need to filter the files by file magic, so we drop it. Previously, it seems that the behavior was flaky. The