OTOH maybe I just need to adopt a merge first strategy to avoid embarrassing
accidental closures...
Anyway, thanks for the nice cleanups.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #1071 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1071#event-3064645142___
Rpm-maint mailing list
Doh, certainly didn't intend to close but just comment and then merge.
Been multiple such mistakes from me in the last week or so, wonder if some
button order or such on GH changed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Reopened #1071.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1071#event-3064556851___
Rpm-maint mailing list
Okay so there was more than meets the eye... thankfully caught by the
test-suite.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1071.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1071#event-3064556636___
Rpm-maint mailing list
@mlschroe pushed 1 commit.
4db183db61ca56d035712ca752234aa7c8e8b097 Only look at symlinks in new packages
in fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@mlschroe pushed 1 commit.
fe90d1990af3809b9f1174bbf77e458435154328 Only look at symlinks in new packages
in fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@mlschroe pushed 1 commit.
841134ef4697842f1fb3ef4bb2f3993deb8f2a5c Only look at symlinks in new packages
in fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Oh yes, we'll need to do the rpmfilesFpLookup() call for TR_REMOVED packages.
Fixing...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This crashes at the "reinstall 1" test with the following (from valgrind):
> fprint.c:262:12: runtime error: member access within null pointer of type
> 'const struct fingerPrint'
==943715== Invalid read of size 4
==943715==at 0x4923867: fpHashFunction (fprint.c:262)
==943715==by
@mlschroe pushed 1 commit.
954c491165cacf9156d2e4b0f3afaaaef9c3d529 Only look at symlinks in new packages
in fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
mlschroe commented on this pull request.
> pi = rpmtsiInit(ts);
while ((p = rpmtsiNext(pi, 0)) != NULL) {
fingerPrint *fpList;
(void) rpmsqPoll();
+ if (rpmteType(p) == TR_REMOVED)
+ continue; /* we are only interested in new packages */
pmatilai commented on this pull request.
> pi = rpmtsiInit(ts);
while ((p = rpmtsiNext(pi, 0)) != NULL) {
fingerPrint *fpList;
(void) rpmsqPoll();
+ if (rpmteType(p) == TR_REMOVED)
+ continue; /* we are only interested in new packages */
I've added a commit that makes the code only consider symlinks. Florian, any
objections to this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mlschroe pushed 1 commit.
1732cc787d6f508019edc7c455aa02d9b9ad78e6 Only look at symlinks in new packages
in fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Good question, I've no idea. @ffesti?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1071#issuecomment-587491783___
Rpm-maint
I didn't plan to push more commits, but now that you ask:
Does it really make sense to have the symlinks of already installed packages in
the `symlinks` hash? If a symlink is deleted on disk, the code will ignore it
anyway (see the "Ignore already removed (by eg %pretrans) links" comment). If
> I'm trying to make dir -> symlink-to-dir transactions work in the easy cases,
> I think this will be fixed with the changes as well
Wow. Good luck with that :grin:
As for the slashes, I seem to recall looking at reducing them but something
preventing that, perhaps some "hidden" dependency
Regarding your b81b4a35240f16fa8b45156b0151fab9e130a8e8 commit:
fpLookupSubdir's slash handling is still somewhat broken, it tends to duplicate
slashes when creating the link. The fingerprint lookup fortunately calls
rpmCleanPath() with gets rid of the extra slashes again.
BTW, why do the
Ok, that's what I thought. But it's somewhat brittle, that example from the
mail will not work if FOO-DOC is installed before FOO as then /usr/share/FOO-1
will get created as directory and the install of FOO will fail with a
RPMERR_EXIST_AS_DIR error.
(I'm trying to make dir -> symlink-to-dir
Yes, that's pretty much it. The finger printing code calculates a unique
identifier for each file's location. This is comprised out of the device id and
inode number of the parent dir and the filename. If the parent dir is not on
disk yet, the closest dir is used + the path down to the parent
In case you wonder, I remember due to encountering this during the string-pool
mass changes, and I do remember having a manual test-case for commit
b81b4a35240f16fa8b45156b0151fab9e130a8e8. Too bad I didn't create an automated
test back then :disappointed:
--
You are receiving this because
IIRC this is the reproducer case:
http://lists.rpm.org/pipermail/rpm-maint/2008-April/002051.html
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Ok, I have to admit I'm not entirely sure what fpLookupSubdir is trying to fix.
It was added by Florian in commits c6ccc90d7fef0f1b65e4bf5b77d5b800d4b53ffd and
af3464a053ecb0b56cc5af494ea22955fb350757, unfortunately without a reference to
some bug.
It seems to be about having a symlink in one
@mlschroe pushed 1 commit.
1c9343142a728dce571ee0c8ce4f6fae42354588 Reduce the number of calls to
fpLookupSubdir()
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
This reduces the number of calls to fpLookupSubdir() and also gets rid of a
poolid-str-poolid roundtrip.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1071
-- Commit Summary --
* fpLookupSubdir: get rid of a
27 matches
Mail list logo
