Re: [Rpm-maint] [rpm-software-management/rpm] Permit secondary index open to fail for bdb_ro (#1578)
Merged #1578 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1578#event-4480394413___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Permit secondary index open to fail for bdb_ro (#1578)
@pmatilai pushed 1 commit. 88b47ae2a1471d0ce11b034bf9529f8a89a29754 Permit secondary index open to fail for bdb_ro -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1578/files/d0a579f3b6c6d1e93d9ff87ad06c59b0fe3e16f5..88b47ae2a1471d0ce11b034bf9529f8a89a29754 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Permit secondary index open to fail for bdb_ro (#1578)
Hmm, while this does cover the case is #1576 it'll segfault if there are no secondary indexes at all. So this isn't a proper solution, just first-aid. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1578#issuecomment-799353571___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Permit secondary index open to fail for bdb_ro (#1578)
The other backends would want to create the missing index, but as bdb_ro is read-only it cant do that. As the main purpose of bdb_ro is to support migrating away from BDB for which only the primary database is needed, it doesnt make sense to fail it for non-essential data. Let it fail for secondary indexes - this might affect our ability to query but thats secondary, literally, and we also do emit a warning here. Fixes: #1576 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1578 -- Commit Summary -- * Fix bdb_ro index open error handling * Permit secondary index open to fail for bdb_ro -- File Changes -- M lib/backend/bdb_ro.c (14) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1578.patch https://github.com/rpm-software-management/rpm/pull/1578.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1578 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
