Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
Merged #1245 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#event-3385730799___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
Anyway, the DB discussion is a separate topic. Thanks for the doc review guys, fixed in the last push. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635775456___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
There's at least one thing that needs to be dealt with one way or the other before dropping BDB can be seriously considered: ``` [pmatilai︎lumikko rpm]$ grep %_db_backend macros.in %_db_backend bdb ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635773621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai pushed 1 commit. 294692aadac5c9723b022f6f3169d16139dc1a74 Remove support for NSS -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245/files/2786179da12033257d6f006046a2d0e443136bdf..294692aadac5c9723b022f6f3169d16139dc1a74 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai commented on this pull request. > @@ -14,24 +14,13 @@ The source for the file utility + library is available > from ftp://ftp.astron.com/pub/file/ You will need a cryptographic library to support digests and signatures. -This library may be libgcrypt, Mozilla NSS, OpenSSL or beecrypt. +This library may be libgcrypt, Mozilla NSS or OpenSSL. Of course. Thanks for spotting. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#discussion_r432266248___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@Conan-Kudo requested changes on this pull request. > @@ -14,24 +14,13 @@ The source for the file utility + library is available > from ftp://ftp.astron.com/pub/file/ You will need a cryptographic library to support digests and signatures. -This library may be libgcrypt, Mozilla NSS, OpenSSL or beecrypt. +This library may be libgcrypt, Mozilla NSS or OpenSSL. This should be `libgcrypt or OpenSSL`, ne? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#pullrequestreview-420463401___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#pullrequestreview-420462821___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai Come on, drop BDB! Go for the gold! 磊 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635586247___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai commented on this pull request. > Which library to use can be specified with the ---with-crypto=[libgcrypt|beecrypt|nss|openssl] argument to configure, +--with-crypto=[libgcrypt|nss|openssl] argument to configure, Oh, of course. Thanks for spotting! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#discussion_r431834471___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@voxik commented on this pull request. > Which library to use can be specified with the ---with-crypto=[libgcrypt|beecrypt|nss|openssl] argument to configure, +--with-crypto=[libgcrypt|nss|openssl] argument to configure, Shouldn't be the NSS references removed similarly to beecrypt? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#pullrequestreview-420103380___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai oh, in that case - I would ditch bdb backend and possibly enable bdb_ro by default for 4.17 and then in 4.18 disable it by default. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635344736___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
Actually BDB too is already marked deprecated in 4.16 (commit fc0169eb03c893d63dc44f2ada954d42e0e759ed) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635287573___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
@pmatilai I think we need to deprecate it in 4.17 and ditch it in 4.18 while keeping bdb_ro only. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635286229___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
Flushing BDB down the same drain is really, really, really tempting :innocent: but maybe not *just* yet... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635280546___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
:rocket: :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245#issuecomment-635278798___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Remove deprecated beecrypt and NSS crypto backends (#1245)
Shedding some weight to celebrate the beginning of a new cycle :fireworks: You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1245 -- Commit Summary -- * Bump version to mark beginning of a new development cycle * Remove support for beecrypt * Remove support for NSS -- File Changes -- M INSTALL (15) M Makefile.am (2) M build/Makefile.am (2) M configure.ac (65) M lib/Makefile.am (2) M rpm.pc.in (2) M rpmio/Makefile.am (20) D rpmio/digest_beecrypt.c (507) D rpmio/digest_nss.c (532) M sign/Makefile.am (2) M tests/rpmsigdig.at (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1245.patch https://github.com/rpm-software-management/rpm/pull/1245.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1245 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
