Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)
The other thing is that leaving regressions sitting in the tree with the notion that somebody will fix it at some point is just not okay at all: that s*** *will* accumulate and cause hell to pay when the time to make the next release comes. *Ideally* rpm should be release ready at any given commit. As a general rule, if a regression can't be fixed on the spot, it's usually better to revert and rethink. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286#issuecomment-650064212___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)
Merged #1286 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286#event-3476208995___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)
Nah, it deserves to be reverted because it can't be fixed by any one little thing, it's broken in more ways than we have tickets for and we have two already. It really needs a restart from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286#issuecomment-648650897___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)
I think we should keep it for master and revert fo 4.16 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286#issuecomment-648649214___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)
This is simply too broken to patch up. Revert and back to drawing board. This reverts commit fb5299b2a49460216c38674b7398296d3a6d767c. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1286 -- Commit Summary -- * Revert Always fail build on dependency generator failures (#1183) -- File Changes -- M build/rpmfc.c (32) M tests/rpmbuild.at (36) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1286.patch https://github.com/rpm-software-management/rpm/pull/1286.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
