Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
Merged #1347 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#event-3744961445___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#pullrequestreview-483165088___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
Edit: commit message updated to talk about _minimize_writes instead of _minimize_io. And here I was wondering why I can't seem to reproduce it now... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#issuecomment-684792915___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
Test-case added, but still needs that second set of :eyes: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#issuecomment-684792042___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
@pmatilai pushed 1 commit. f22f7cc156822d6ffae77ad5101150f2514a5e9f Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347/files/34f715884461dd91ee7f1430619d0da95e218b2a..f22f7cc156822d6ffae77ad5101150f2514a5e9f ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
This needs a test-case, and somebody else to look through the code. I'm not entirely well this week. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#issuecomment-681864201___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
When %_minimize_io is enabled, we determine unchanged files during fingerprinting and only update their metadata (FA_TOUCH) instead of always recreating from scratch (FA_CREATE) during install. However package scriptlets (and administrators) can and will do arbitrary stuff in the meanwhile, such as rm -f their own files in %pre, hoping to get a fresh copy of contents no matter what. Or something. Now, if the file was determined to not need changing by rpm, this will just fail with chown & friends trying to touch non-existent file. One can consider this a case of package shooting itself in the foot, but when a package update fails or succeeds depending on %_minimize_io this to me suggests the feature is at fault as much as the package. Do fsmVerify() on all files to be FA_TOUCH'ed to detect files whose type changed or were removed since fingerprinting. This still doesn't ensure correctness if something tampers with the contents in the meanwhile, (for that we'd need to run the file through the whole machinery again, checksumming and all) but covers the most glaring cases. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1347 -- Commit Summary -- * Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) -- File Changes -- M lib/fsm.c (15) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1347.patch https://github.com/rpm-software-management/rpm/pull/1347.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
