Oh, I don't see experimental status affecting change-per-commit requirement at
all, as the commits will remain forever regardless of the status. Various other
aspects can be somewhat relaxed on experimental code of course.
Anyway, splitting up much appreciated, thanks.
--
You are receiving
Merged #1004 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1004#event-2938440405___
Rpm-maint mailing list
I get that, but I was under the impression that ndb is still marked as
experimental. (That's about to change in the near future, though.)
Anyway, force pushed to multiple commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
These are essentially unrelated changes, hence they belong to separate commits.
It might not seem that valuable to the author, but it makes reviewing much
easier, and the biggest value of strict commit-per-logical-change comes over
time from bisecting, cherry-picking etc.
Lumping such changes
I kind of fail to see the point, but I'll do it anyways just to please you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Please split to individual commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1004#issuecomment-572929304___
Rpm-maint
This commit adds a verify method for ndbs Packages.db database.
It also cleans up the pkgdb code a bit:
* removed unused lzo compression code
* added some more comments and fixed spelling mistakes
* made ordered slots flag a boolean
* fixed a corner case where a package id lookup could segfault
