Merged #1009 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1009#event-2950342476___
Rpm-maint mailing list
Right, I hate these unsilenceable "we know better" warnings too, with a passion.
BTW thanks for the pointer, at least in the newer bug points out there's now a
"nodiscard" attribute that does the right thing for these cases. Guess we
should lobby glibc to adopt that instead of the obnoxious
Reopened #1009.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1009#event-2950287205___
Rpm-maint mailing list
@mlschroe pushed 0 commits.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1009/files/9076d958bf91502eed454283d7daeafece4c6836..471e7d8bb26f0d7be877a261812b8dd8172650d3
Oh my. The gcc people seem to be not too happy about this, but it's hard to fix
because the void cast is optimized away before the unused result check is done.
See:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425
Anyway, fixed to something
pmatilai requested changes on this pull request.
As per above: this doesn't actually change the behavior at all, so NAK.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Casting doesn't silence warnings from functions with warn_unused_result
attribute. You need to actually check the value.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Fixes #1008
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1009
-- Commit Summary --
* ndb: fix ftruncate return value warning
-- File Changes --
M lib/backend/ndb/rpmxdb.c (2)
-- Patch Links --
