Merged #1235 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1235#event-3392226804___
Rpm-maint mailing list
Thanks for the patches!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1235#issuecomment-636722464___
Rpm-maint mailing list
@pmatilai fixed and rebased.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1235#issuecomment-636714949___
Rpm-maint mailing
I'm getting this on Fedora 32:
> rpmbuild.c: In function ‘getTarSpec’:
rpmbuild.c:342:22: error: unused variable ‘res’ [-Werror=unused-variable]
342 | int gotspec = 0, res;
| ^~~
cc1: all warnings being treated as errors
Other than that, looks good I think.
--
As you can see, I'm touching rpmbuild code, morning else. So this should not
break.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ignatenkobrain @pmatilai What about when `rpm -ivh package.src.rpm` is done? I
do this all the time and I expect the directories to be created when I do this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai hopefully should be fixed and rebased.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1235#issuecomment-634501079___
Yup - the point being, parsing the spec simply can not require generating any
directories. If it does, something is very wrong :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
makes sense, I can rework tarball case to create tempdir and set _specdir
there. I guess we can drop creation of sourcedir as well.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
There's also the question whether it should be creating %_specdir and
%_sourcedir at all, as these need to pre-exist anyway. Except for tarbuild, and
the reason tar-build "needs" %_specdir is also dubious, it could just as well
use the current (or temporary) just as it does with %_sourcedir.
@pmatilai FYI, this case have been fixed. This PR works fine from my testing.
Sorry, forgot to type this before :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Yup, the tarball case is an annoying one.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1235#issuecomment-633415937___
Ehh, it seems that this breaks building from tarball :/
I'll check if I can make it work.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I guess this might affect some kind of %include usage, but the difference
between not being able to read file from folder that does not exist or from the
folder that does and is empty is not something what we should be worried about
I think.
--
You are receiving this because you are
Build tree macros can use %{name} or any other kind of weird things in
them. The generation of Name or anything like that from the
%{_sourcedir} or anything like this is not something what people do or
should do. Lets just parse spec first and then create any missing
directories for build tree.
15 matches
Mail list logo
