Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
Thank you too, @pmatilai! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-634522612___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
Thanks for the patches and patience! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-63888___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
Merged #1242 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#event-3376500848___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
> I would move `import re` to the top imports and just be done with it. We can discuss this in a separate issue. It hasn't changed here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-634131378___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
I would move `import re` to the top imports and just be done with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-634120267___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
> This pull request **introduces 1 alert** when merging > [592a6d5](https://github.com/rpm-software-management/rpm/commit/592a6d5980010c63eb76c31ddd8954fba9cbaa92) > into > [8734c1b](https://github.com/rpm-software-management/rpm/commit/8734c1b97e39e3c7d3ac8396c4d6a2733852545c) > - [view on > LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-b6979aa46105339f8a0843eae399433dc33d6444) > > **new alerts:** > > * 1 for Module is imported more than once It's a lazy import so that if it's not needed, it doesn't slow down the execution. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-634119166___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
This pull request **introduces 1 alert** when merging 592a6d5980010c63eb76c31ddd8954fba9cbaa92 into 8734c1b97e39e3c7d3ac8396c4d6a2733852545c - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-b6979aa46105339f8a0843eae399433dc33d6444) **new alerts:** * 1 for Module is imported more than once -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242#issuecomment-634117340___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Various updates and fixes (no test suite) (#1242)
This is a modification of PR https://github.com/rpm-software-management/rpm/pull/1195, where I've deleted all mentions of the test suite. CC @pmatilai, @Conan-Kudo, @ffesti, @hroncok You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1242 -- Commit Summary -- * scripts/pythondistdeps: Also provide pythonXdist() with PEP 503 normalized names * scripts/pythondistdeps: "Fix" support of environment markers * scripts/pythondistdeps: Notes from an attempted rewrite to importlib.metadata * scripts/pythondistdeps: Sort generated provides/requires * scripts/pythondistdeps: Add option to generate major-version provides only for specified Python versions * scripts/pythondistdeps: Implement --normalized-name-* options * scripts/pythondistdeps: Do anything only when called as a main script * scripts/pythondistdeps: Version handling exception with better information * scripts/pythondistdeps: Modify handling of dev versions -- File Changes -- M scripts/pythondistdeps.py (466) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1242.patch https://github.com/rpm-software-management/rpm/pull/1242.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1242 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint