Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
You first chmod -x and then run brp-strip, how is it going to strip debuginfo from *.so?! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#issuecomment-734501309___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
@mikhailnov commented on this pull request. > @@ -0,0 +1,13 @@ +#!/bin/sh +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" ] || [ "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +ELFCLASSIFY=/usr/bin/eu-elfclassify BSD systems will want /usr/local/bin (`./configure --bindir= --prefix=) here -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#pullrequestreview-539570683___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
Merged #1395 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#event-4027884180___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
Okay, this is not in any way exclusive to other improvements in this area and quite clearly is a good thing, so guess we'll just merge this and wonder about the other stuff separately. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#issuecomment-732190905___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
This is very similar to a brp script we have in OpenMandriva downstream that we execute as part of the "spec-helper" buildroot policy script. I think it makes sense to have this so that having a `noexec` library directory is possible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#issuecomment-732157127___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395#pullrequestreview-536463958___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
@pmatilai pushed 1 commit. d276158ec495c5ac919b95a7bf82d7d5fa946da9 Add a build root policy for removing executable bits from shared libraries -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395/files/4e16ec582ebf511013f689f7f8bb6839ca3db448..d276158ec495c5ac919b95a7bf82d7d5fa946da9 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
@pmatilai pushed 1 commit. 4e16ec582ebf511013f689f7f8bb6839ca3db448 Add a build root policy for removing executable bits from shared libraries -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395/files/b76f58803e61ef3a825f622c7c61566372b6a4dd..4e16ec582ebf511013f689f7f8bb6839ca3db448 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add a build root policy for removing executable bits from shared libr… (#1395)
…aries Rpm has traditionally used executable bit on files to determine whether requires for that file should be generated, but the downside is that we have systems full of executable files that cannot actually be executed. When available, use eu-elfclassify to determine files that are pure, non-executable shared objects and remove executable bits from them as a buildroot policy. This preserves the traditional behavior wrt dependency generation but gets rid of the unwanted executable bits. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1395 -- Commit Summary -- * Add a build root policy for removing executable bits from shared libraries -- File Changes -- M platform.in (2) M scripts/Makefile.am (4) A scripts/brp-elfperm (13) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1395.patch https://github.com/rpm-software-management/rpm/pull/1395.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1395 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
