Re: [Rpm-maint] digest_beecrypt cleanup

2013-08-28 Thread Michael Schroeder
On Tue, Aug 27, 2013 at 05:41:42PM +0200, Michael Schroeder wrote: Hi Panu al, the attached patch cleans up the code in digest_beecrypt: [...] - rc = pgpMpiSet(qbits, sig-data, p, pend); + rc = pgpMpiSet(qbits, sig-data); Deleted p parameter by mistake. [...] -for

Re: [Rpm-maint] digest_beecrypt cleanup

2013-08-28 Thread Panu Matilainen
On 08/28/2013 11:18 AM, Michael Schroeder wrote: On Tue, Aug 27, 2013 at 05:41:42PM +0200, Michael Schroeder wrote: Hi Panu al, the attached patch cleans up the code in digest_beecrypt: [...] - rc = pgpMpiSet(qbits, sig-data, p, pend); + rc = pgpMpiSet(qbits, sig-data);

Re: [Rpm-maint] digest_beecrypt cleanup

2013-08-28 Thread Michael Schroeder
On Wed, Aug 28, 2013 at 02:39:35PM +0300, Panu Matilainen wrote: No objections to the changes as such, but please split the patch up a bit: at the very least separate the interface change from the beecrypt-cleanups, but I wouldn't mind the beecrypt cleanups further split up either. That bit

Re: [Rpm-maint] digest_beecrypt cleanup

2013-08-28 Thread Michael Schroeder
On Wed, Aug 28, 2013 at 06:52:48PM +0200, Michael Schroeder wrote: On Wed, Aug 28, 2013 at 02:39:35PM +0300, Panu Matilainen wrote: No objections to the changes as such, but please split the patch up a bit: at the very least separate the interface change from the beecrypt-cleanups, but I

Re: [Rpm-maint] digest_beecrypt cleanup

2013-08-28 Thread Panu Matilainen
On 08/28/2013 08:11 PM, Michael Schroeder wrote: On Wed, Aug 28, 2013 at 06:54:24PM +0200, Michael Schroeder wrote: On Wed, Aug 28, 2013 at 06:52:48PM +0200, Michael Schroeder wrote: On Wed, Aug 28, 2013 at 02:39:35PM +0300, Panu Matilainen wrote: No objections to the changes as such, but