[Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Yuri Dario
I have committed the generic patches to RPM source tree. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/255 -- Commit Summary -- * Fix file signatures not installing * Fix file signatures issue with sig header size

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Igor Gnatenko
it's pretty much impossible to make any review here =( because files are mixed and so on. so please rebase it and force-push. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Igor Gnatenko
I suppose those changes were made against 4.13, but you need to rebase them against master -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Igor Gnatenko
khm, that doesn't sound right ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/255#issuecomment-315306696___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Yuri Dario
Son_Goku told me patches were ready for PR, but we spoke about rebasing too. So I opened the request to wait for comments :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13.x os2 code changes (#255)

2017-07-14 Thread Yuri Dario
ok, going with rebase -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/255#issuecomment-315308984___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Jeff Johnson
@mischroe: DB_PRIVATE has its own associated durability/signal problems, including that ^C is masked while installing, and with the transaction lock being for exclusive writers, not readers. Truly ^C handling needs to be solved intelligently, not with convoluted contortions to BDB

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Jeff Johnson
I'm happy it works fine for SuSE: I'm sure you have tested. Meanwhile ^C exiting and calling rpmdbClose is a problem that needs to be solved without convoluted BDB configuration changes. Its tiresome to continuously revisit this issue, in patches and bug reports. -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Colin Walters
Just a note to remember that for generating new roots (i.e. not inplace upgrades), we can just let SIGINT kill us. For rpm-ostree, every operation is a new root, so we [turn off rpm's SIGINT

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Michael Schroeder
Trust me, the patch works fine for the setup used at SUSE. But I agree that it makes no sense to merge it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Michael Schroeder
(It works for SUSE because we always open with DB_PRIVATE and thus don't use the dbenv at all. So there's no ignorant denial involved ;-) ) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Don't modify interupts if db is read only (#251)

2017-07-14 Thread Simon Lees
I guess thats something else we should upstream or standardize with upstream on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: