superseded by #295
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/283#issuecomment-319600646___
Rpm-maint mailing list
My personal preference is to keep $prefix/lib/rpm hardcoded. We do this in
systemd, casync and a lot of other tools.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This can be named in various different ways, especially in cross-compilation
environments, so let's take it from the build setup.
This is a much simpler and less invasive version of an earlier patch: it simply
changes references to $(prefix)/lib/rpm, so that they become $(libdir)/rpm.
Hopefully
@Conan-Kudo In Yocto project the libdir can be lib, lib32, lib64, or anything
else. You cannot assume anything about it, and when building the software, the
value for it is typically passed to ./configure as a command line switch.
On the other hand, %_libdir macro hardcodes the value to be
pmatilai commented on this pull request.
> @@ -864,6 +865,27 @@ doFoo(MacroBuf mb, int negate, const char * f, size_t fn,
if ((b = strrchr(buf, '/')) != NULL)
*b = '\0';
b = buf;
+} else if (STREQ("shrink", f, fn)) {
+ /*
+* shrink body by removing
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/297
-- Commit Summary --
* add support for zstd compressed payload
* ci: Add libzstd-devel to CI Dockerfile
-- File Changes --
M build/pack.c (6)
M
Superseded by #297
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/295#issuecomment-319632547___
Rpm-maint mailing list
Closed #263.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/263#event-1189319031___
Rpm-maint mailing list
@pmatilai I think I fixed all nitpicks ;)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/296#issuecomment-319634624___
On Fri, 2017-07-28 at 23:24 +0200, Mark Wielaard wrote:
> If split debuginfo code doesn't know about RemovePathPostfixes it fails:
>
> error: Installed (but unpackaged) file(s) found:
>/usr/lib/debug/bin/hello.foobar-1.0-1.x86_64.debug
This one also now passes with Igor's fixes.
On Fri, 2017-07-28 at 23:24 +0200, Mark Wielaard wrote:
> If split debuginfo code doesn't know about excluded files it fails:
>
> error: Installed (but unpackaged) file(s) found:
>/usr/lib/debug/bin/hello3-1.0-1.x86_64.debug
And with Igor's fixes this test now passes.
On Fri, 2017-07-28 at 21:55 +0200, Mark Wielaard wrote:
> This adds various tests for making sure multiple subpackages are build
> correctly. Without debuginfo subpackages, with subpackages, subpackages
> with unique debug file and source dir paths and with separate debugsources.
Ping. These are
superseded by #296 which fixes some style issue in code + adds test
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai We could at least move things to `$(libexecdir)/rpm` and for Fedora
have a symlink for the old location to point to the new one. That'd keep things
consistent, right?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@kanavin The values in macros.in are overridden by the generated platform
macros: https://github.com/rpm-software-management/rpm/blob/master/platform.in
As far as I know, as long as you aren't purging the platforms, this doesn't
matter.
--
You are receiving this because you are subscribed to
pmatilai commented on this pull request.
> +} else if (STREQ("shrink", f, fn)) {
+ /*
+* shrink body by removing all leading and trailing whitespaces and
+* reducing intermediate whitespaces to a single space character.
+*/
+ int i, j, k, was_space = 0;
+
@Conan-Kudo in Yocto the generated platform macros are not used, as there is a
hardcoded list of those platforms, which is not flexible enough for us. So we
directly override settings from the default macros file at runtime.
However, for some reason _libdir is not overriden in the same way, and
@pmatilai Okay, splitting things into two places is bad. How about not
hardcoding the 'lib' part? Should I open a separate PR for it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Conan-Kudo requested changes on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
If this is linked in from librpmio, there's no reason to add
`Requires.private`, right? We
Hi,
On Fri, 2017-07-28 at 15:29 +0200, Mark Wielaard wrote:
> + if [ ! -s "$srcout" ]; then
> +echo >&2 "*** WARNING: No source files found. Creating empty
> debugsource package"
> +# Create the empty directory.
> +# See also debugedit invocation. Directories must match up.
> +
this will break existing distributions.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/298#issuecomment-319643940___
Rpm-maint
ignatenkobrain commented on this pull request.
> @@ -351,6 +351,9 @@ int rpmFileIsCompressed(const char * file,
> rpmCompressedMagic * compressed)
(magic[4] == 0x5a) && (magic[5] == 0x00)) {
/* new style xz (lzma) with magic */
*compressed = COMPRESSED_XZ;
+}
@kanavin I still don't understand why $prefix/lib/rpm is a problem. This
location is even described in FHS. so Yocto doesn't support FHS?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I just want to settle this question going forward: should these references be
hardcoded to /usr/lib, which is less pain for existing distributions, but more
pain for Yocto, as we have to fix every instance of such hard coding (that also
includes the rest of dnf stack, and various other
The Yocto Project doesn't mandate any particular userspace layout. You can
configure it to match FHS but we expect software to match the configuration
that is set. The issue here is that rpm doesn't honour our configuration
settings. People can and do change the layouts for various reasons, I
> /usr/lib includes object files and libraries. [21] On some systems, it may
> also include internal binaries that are not intended to be executed directly
> by users or shell scripts. [22]
> ...
> [22] See below, in the /usr/libexec section, for a discussion of /usr/lib vs.
> /usr/libexec for
It is a problem for multilib environments which are very common in embedded
space. Yocto has had full support for it for a long time, but it does require
that nothing hardcodes the /usr/lib assumption, and instead installs its stuff
where it is told to by the build environment.
ignatenkobrain commented on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
this is mostly if you would like to do `pkg-config --static --cflags --ldflags
rpm` to link
ignatenkobrain commented on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
well, we do for Libraries.private... but since we use pkg-config for zstd, it
is better to put
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Wed, 2017-08-02 at 13:09 +0200, Mark Wielaard wrote:
> Hi,
>
> On Fri, 2017-07-28 at 15:29 +0200, Mark Wielaard wrote:
> > + if [ ! -s "$srcout" ]; then
> > +echo >&2 "*** WARNING: No source files found. Creating empty
> > debugsource
30 matches
Mail list logo
