Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)

2020-01-15 Thread DuratarskeyK
We use a weird version of rpm, which computes data size by subtracting next offset from the current one, which yields 18 bytes and then MD5 check fails. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)

2020-01-15 Thread Panu Matilainen
That's a bug in your rpm, optimization that gets wrong results on exact data is not a legit optimization. We actually had the same bug although in slightly limited form, see #398 for the discussion and fix. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)

2020-01-15 Thread Panu Matilainen
Closed #1010. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1010#event-2950016749___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Panu Matilainen
pmatilai requested changes on this pull request. As per above: this doesn't actually change the behavior at all, so NAK. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2020-01-15 Thread Panu Matilainen
Sorry for dropping the ball here, seems obvious enough to me. Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#issuecomment-574569382__

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2020-01-15 Thread Panu Matilainen
Merged #927 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#event-2950049257___ Rpm-maint mailing list Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add --zlib-compress-debug-sections to find-debug-info.sh (#795)

2020-01-15 Thread Panu Matilainen
Dusting off old PRs... Has this gone into openSUSE by now, any experiences collected? At any rate, you'll need to rebase this PR and get rid of the extra merge commit in order to proceed. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https:

Re: [Rpm-maint] [rpm-software-management/rpm] build: check rich dependencies for special characters (4.14.x) (#605)

2020-01-15 Thread Panu Matilainen
Closed #605. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/605#event-2950093383___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] build: check rich dependencies for special characters (4.14.x) (#605)

2020-01-15 Thread Panu Matilainen
But then, we process backports in batches anyway so this is not going to be merged via this PR anyway, closing. Still, we need to come up with a way to earmark commits for inclusion in stable releases, and a more open process for doing those stable updates in general. -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Michael Schroeder
Oh my. The gcc people seem to be not too happy about this, but it's hard to fix because the void cast is optimized away before the unused result check is done. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 Anyway, fixed to something t

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Michael Schroeder
@mlschroe pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009/files/9076d958bf91502eed454283d7daeafece4c6836..471e7d8bb26f0d7be877a261812b8dd8172650d3 _

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Michael Schroeder
Closed #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950269608___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Michael Schroeder
Reopened #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950287205___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Panu Matilainen
Right, I hate these unsilenceable "we know better" warnings too, with a passion. BTW thanks for the pointer, at least in the newer bug points out there's now a "nodiscard" attribute that does the right thing for these cases. Guess we should lobby glibc to adopt that instead of the obnoxious warn_

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Panu Matilainen
pmatilai approved this pull request. This is quite a reasonable way to get around the dumb warning in general I think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/10

Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)

2020-01-15 Thread Panu Matilainen
Merged #1009 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950342476___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] ndb compilation fails with -Werror on gcc 9.2.1 / glibc 2.30 (#1008)

2020-01-15 Thread Panu Matilainen
Closed #1008 via #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1008#event-2950342480___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)

2020-01-15 Thread Michael Schroeder
FYI: I had to revert the ndb glue change, as it caused segfaults if just an index dbi got closed. The commit doesn't contain any information about the problem it tries to solve, do you remember why your change was necessary? -- You are receiving this because you are subscribed to this thread. R

Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)

2020-01-15 Thread Panu Matilainen
Hmm, the ndb glue change here looks decidedly wrong to me, the thing is reference counted for a reason (guess this shows just how much attention I've been paying to ndb changes, and I guess that needs to change from now on) -- You are receiving this because you are subscribed to this thread. Re

Re: [Rpm-maint] [rpm-software-management/rpm] Add NEVR provides for all packages that would be built into source rpms (#891)

2020-01-15 Thread Panu Matilainen
Merged #891 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/891#event-2950529863___ Rpm-maint mailing list Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add NEVR provides for all packages that would be built into source rpms (#891)

2020-01-15 Thread Panu Matilainen
Since there are no objections... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/891#issuecomment-574627598___ Rpm-maint mailing

[Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)

2020-01-15 Thread mikhailnov
I have been writing an RPM generator (https://rpm.org/user_doc/dependency_generators.html) and I can't understand which output format it must have. Script is here: https://abf.io/import/devel-rpm-generators/ It simply does not work, no provides/requires are generated, I have looked into `pkgconf

Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)

2020-01-15 Thread Alan Jenkins
Bad reading, bad patch. Sorry for the NULL pointer dereference. I'm not sure, I might have mixed up somewhere with the different backends. That said, the real problem could have been confusion about the code that calls closeEnv(). It doesn't seem to make sense to test if `rdb->db_dbenv` is NU

Re: [Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)

2020-01-15 Thread mikhailnov
I have found what was wrong ("NAME needs to be replaced by the name choosen for the file attribute and needs to be the same as the file name of the macro file itself"). But please document the input and output format. `pkgconfigdeps.sh` uses `echo -n 'value '` and then `echo` an empty line, `fi

Re: [Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)

2020-01-15 Thread mikhailnov
Maybe `echo -n ` is used to additionally print `= XXX`, then the output format must be just line-by-line values? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1011#issu