Updated as per @ffesti's idea to always always push a value on the optimization
macros so we can easily revert to original state by popping the macros.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Feels awfully fiddly still, and somehow this makes me think there should be a
new config value to enable the ssd autodetection, because otherwise to override
its effect now you need to set *two* macros instead of just one. Which feels
wrong.
One way around that would be only enabling
Do you have a case where the STRIP_TRAILINGSPACE thing actually makes a
difference?
As commit b7d427728b8ba8734ba47d51849a5736bdd727cd where readManifest() is
added notes:
> STRIP_TRAILINGSPACE is a bit misleading here as it actually affects whether
> a newline is added or not, but that's
pmatilai commented on this pull request.
> @@ -745,12 +745,14 @@ package or when debugging this package.\
%_pkgverify_flags 0x0
# Set to 1 to minimize writing (at the cost of more reads) to
-# conserve eg SSD disks.
-%_minimize_writes 0
+# conserve eg SSD disks. Set to -1 for enabling
pmatilai commented on this pull request.
> + rpmPushMacro(NULL, "_minimize_writes", NULL, "1", 0);
+ } else {
+ char * val = rpmExpand("%{_minimize_writes}", NULL);
+ rpmPushMacro(NULL, "_minimize_writes", NULL, val, 0);
+ _free(val);
+ }
+
@pmatilai pushed 2 commits.
e966e703d1500d1050c238a50c4da48d0cc83c72 Only enable flush_io and
minimize_writes on positive values
3ba2e8beb82b847af1b4bb6db48b2d88989fc45d Auto-enable optimizations for
non-rotational disks on Linux
--
You are receiving this because you are subscribed to this
pmatilai commented on this pull request.
>
# Set to 1 to flush file IO during transactions (at a severe cost in
-# performance for rotational disks)
-#%_flush_io0
+# performance for rotational disks). Set to -1 for enabling when running on
+# SSDs. Set to 0 for always off.
+%_flush_io
Simplify the way the fingerprint cache is created.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1068
-- Commit Summary --
* Move fingerprint hash setting out of fpLookupSubdir()
* Remove duplicated code in
It gets only written to and nobody uses it, so be gone.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1069
-- Commit Summary --
* fsmMkdirs: Remove dnlx array
-- File Changes --
M lib/fsm.c (8)
-- Patch Links --
@mlschroe pushed 1 commit.
c410531402fe2541566d16b963b1ed575cab8ea9 fsmMkdirs: Remove dnlx array
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@mlschroe pushed 1 commit.
6232c8e1e515833f3a51af2800d3ab70d82a9e05 fsmMkdirs: do not dup the last
verified directory name
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
pmatilai commented on this pull request.
> +spec->lineNum, name, poptStrerror(rc));
+ goto exit;
+}
+
+optCon = poptGetContext(NULL, argc, argv, optionsTable, 0);
+while ((arg = poptGetNextOpt(optCon)) > 0) {
+
+ char * filename = poptGetOptArg(optCon);
+
Nice finding.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1061#issuecomment-585614753___
Rpm-maint mailing list
You still need to be able to BR them because you'd want to run tests and
whatnot.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
14 matches
Mail list logo
