You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1078
-- Commit Summary --
* Remove capabilities instead of setting empty caps via. --setcaps
* Add + use a bitmask for order-agnostic dependency types
* Add support for
This pull request **fixes 1 alert** when merging
025537a689d8016d086935afda82266c3fa0199c into
4a9440006398646583f0d9ae1837dad2875013aa - [view on
LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-dca2d891d691d6eba68127307abea1cabcc8d08c)
**fixed alerts:**
* 1 for FIXME
pmatilai commented on this pull request.
> +spec->lineNum, name, poptStrerror(rc));
+ goto exit;
+}
+
+optCon = poptGetContext(NULL, argc, argv, optionsTable, 0);
+while ((arg = poptGetNextOpt(optCon)) > 0) {
+
+ char * filename = poptGetOptArg(optCon);
+
In our package (nss), the release tarballs contain an extra directory hierarchy
`nss-X.XX/nss`, while the upstream repo doesn't have it. So we need to use
`pushd nss` and `popd` to apply patches from upstream. This practice doesn't
work well with `%autosetup`, and even if we split the call to
> readFileManifest strips them manually
We seem to be talking about two different codebases, I don't see anything like
that in here:
https://github.com/rpm-software-management/rpm/blob/879dbdc0201f02fc0a04516be6f4c3e4a7a4fdd4/build/files.c#L2273
And looking at rpm 4.14 version of
> Do you have a case where the STRIP_TRAILINGSPACE thing actually makes a
> difference?
> As commit
> [b7d4277](https://github.com/rpm-software-management/rpm/commit/b7d427728b8ba8734ba47d51849a5736bdd727cd)
> where readManifest() is added notes:
>
> > STRIP_TRAILINGSPACE is a bit misleading
Regarding your b81b4a35240f16fa8b45156b0151fab9e130a8e8 commit:
fpLookupSubdir's slash handling is still somewhat broken, it tends to duplicate
slashes when creating the link. The fingerprint lookup fortunately calls
rpmCleanPath() with gets rid of the extra slashes again.
BTW, why do the
Well, the question is whether we need minimize_writes and flush_io as separate
parameters. If we think we do there is really no less complicated option.
Adding a third switch really doesn't help. I'd rather set them both to
autodetect pre default and have people that really need something else
ffesti commented on this pull request.
> +spec->lineNum, name, poptStrerror(rc));
+ goto exit;
+}
+
+optCon = poptGetContext(NULL, argc, argv, optionsTable, 0);
+while ((arg = poptGetNextOpt(optCon)) > 0) {
+
+ char * filename = poptGetOptArg(optCon);
+
Ok, that's what I thought. But it's somewhat brittle, that example from the
mail will not work if FOO-DOC is installed before FOO as then /usr/share/FOO-1
will get created as directory and the install of FOO will fail with a
RPMERR_EXIST_AS_DIR error.
(I'm trying to make dir -> symlink-to-dir
IIRC this is the reproducer case:
http://lists.rpm.org/pipermail/rpm-maint/2008-April/002051.html
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Three problems with it:
>
> 1. It would be regressive to current functionality for no good reason.
> 2. We don't have a way of distributing this in any kind of reasonable
> fashion through rpm-extras.
> 3. IMO, That's not what rpm-extras is for. It's for staging things to
>
In case you wonder, I remember due to encountering this during the string-pool
mass changes, and I do remember having a manual test-case for commit
b81b4a35240f16fa8b45156b0151fab9e130a8e8. Too bad I didn't create an automated
test back then :disappointed:
--
You are receiving this because
Yes, that's pretty much it. The finger printing code calculates a unique
identifier for each file's location. This is comprised out of the device id and
inode number of the parent dir and the filename. If the parent dir is not on
disk yet, the closest dir is used + the path down to the parent
That sounds really, really bizarre and wrong.
headerUnlink() is an internal-only leftover, you always simply call
headerFree() when you're done with it, and that takes care of the refcount
internally. There aren't that many cases where you'd call headerLink() either,
typically its used to hang
The verify method on sqlite backend was buggy due to misunderstanding what and
how PRAGMA integrity_check reports things. In addition, let sqlite
do a foreign key check on our indexes on verify.
You can view, comment on, or merge this pull request online at:
The "obviously correct" fix in commit ab601b882b9d9d8248250111317615db1aa7b7c6
causes rpm --root installs to spit out errors that were not there before, eg
> error: setexecfilecon: (/usr/sbin/glibc_post_upgrade.x86_64) No such file or
> directory
15:bash-4.4.19-2.fc28
It was definitely weird and confusing and after staring at it for a while, I
decided to ask. However, running regular rpm operations with my modified
librpm that displays the reference count showed everything behaving normally.
The bug has to be in my code.
Looked at it again just now and
Closed #1072.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1072#event-3043972015___
Rpm-maint mailing list
19 matches
Mail list logo
