Not a fan of the %__multiarch_deps macro tbh.
First it does not allow to completely switch to the new multiarch-deps whihc is
something distributions probably want to do at some point. So it does not
remove the need to eventually patch the .attr file.
The other question is whether there should
This gets rid of a couple of id-str-id roundtrips and also makes the
dependency hashes in rpmtsCheck() use pool ids instead of strings.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1081
-- Commit Summary --
* Add
Otherwise this looks pretty reasonable.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-589081451___
Rpm-maint
That would definitely be useful, thanks for looking at it! Can you extend the
concept to macro arguments please? My macro files are full of:
```lua
local processall = (rpm.expand("%{-a}") ~= "") and (rpm.expand("%{-z}") == "")
localverbose = (rpm.expand("%{-v}") ~= "")
--
You are
Conan-Kudo requested changes on this pull request.
It's a good first start, just some initial nits...
> @@ -395,6 +395,7 @@ AC_SUBST(WITH_OPENSSL_LIB)
WITH_LIBGCRYPT_INCLUDE=
WITH_LIBGCRYPT_LIB=
if test "$with_crypto" = libgcrypt ; then
+ AC_DEFINE(WITH_LIBGCRYPT, 1, [Build with libgcrypt
