Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Igor Gnatenko
@ignatenkobrain commented on this pull request. > +parser.add_argument('-P', '--provides', action='store_true', help='Print > Provides') +parser.add_argument('-R', '--requires', action='store_true', help='Print Requires') +parser.add_argument('-r', '--recommends', action='store_true',

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Steve Kowalik
@s-t-e-v-e-n-k pushed 1 commit. 0afbfbb67b8b5d8346271a7d8d2351ad4ed0f411 scripts/pythondistdeps: Switch to argparse -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Steve Kowalik
@s-t-e-v-e-n-k commented on this pull request. > +parser.add_argument('-P', '--provides', action='store_true', help='Print > Provides') +parser.add_argument('-R', '--requires', action='store_true', help='Print Requires') +parser.add_argument('-r', '--recommends', action='store_true',

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Igor Gnatenko
@ignatenkobrain commented on this pull request. > +parser.add_argument('-P', '--provides', action='store_true', help='Print > Provides') +parser.add_argument('-R', '--requires', action='store_true', help='Print Requires') +parser.add_argument('-r', '--recommends', action='store_true',

Re: [Rpm-maint] [rpm-software-management/rpm] Warn on undefined components in buildtree macros (#1169)

2020-04-16 Thread Panu Matilainen
OTOH maybe we'll just go with this one for now, it has the benefit of being applicable to 4.15 too... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request. Someone finally did something that has been on my TODO for me.  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Deprecate NSS (#1182)

2020-04-16 Thread ニール・ゴンパ
The NSS library often changes in ways that somehow breaks rpm, and these days upstream does not care about consumers of NSS other than itself. This inflicts untold amounts of suffering on users of rpm in distributions where rpm is linked to NSS. Now that we have a couple of good, well-supported

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread torsava
This very much breaks my pull request I'm preparing — it seems that once you start working on pythondistdeps, everyone gets notification about it and starts working on it too :) — but it's beautiful and I'm all for it! -- You are receiving this because you are subscribed to this thread. Reply

Re: [Rpm-maint] [rpm-software-management/rpm] Remove nss backend from rpm (#1175)

2020-04-16 Thread Panu Matilainen
Closed #1175 via #1182. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1175#event-3239767503___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Deprecate NSS (#1182)

2020-04-16 Thread Panu Matilainen
Merged #1182 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1182#event-3239767498___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Deprecate NSS (#1182)

2020-04-16 Thread Panu Matilainen
@pmatilai approved this pull request. Fine by me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Panu Matilainen
While on the subject - are all those added empty lines due to some flake8 warnings? I like visual aides as much as the next guy, but I do disagree with wasting perfectly good screen estate with two consecutive empty lines when one will do the trick already :grin: -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Panu Matilainen
Nice, but please don't mix whitespace changes with code changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Panu Matilainen
Splitting to a separate commit would be great, no need to make a separate PR though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: optional one-shot/cached macro expansion (#1155)

2020-04-16 Thread Panu Matilainen
Yeah, %define with options is what I'd really like (I think I even mentioned somewhere surrounding the pending %literal). In macro files the name limitation could be abused for similar effect by adding special characters in the front of the name. AIUI rpm5 used "." to denote a read-only

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Steve Kowalik
Would you like me to revert that part of the change? They are fairly self-contained, so easy enough to pull out in a separate change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Steve Kowalik
Yes, flake8 warns on needing two blank lines, not one. https://www.flake8rules.com/rules/E302.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Switch to argparse (#1181)

2020-04-16 Thread Panu Matilainen
Right, so it's an [upstream Python guideline](https://www.python.org/dev/peps/pep-0008/#blank-lines) that I wasn't even aware of. I'll just agree to disagree with that then, so nevermind :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Remove nss backend from rpm (#1175)

2020-04-16 Thread Panu Matilainen
Be my guest... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1175#issuecomment-614530275___ Rpm-maint mailing list