Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-04 Thread Panu Matilainen
Yes I realize DBUS API is an entirely different thing. The reason for bringing it up here is to think forward in terms of the names used etc - eg org.rpm.Transaction is something I could imagine wanting to use in such an API, rpm.org.announce probably not. -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Support rpm version comparison in expressions (#1233)

2020-06-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -15,6 +15,7 @@ #include #include +#include Yup, preinstall.am sometimes needs a little kick (aka rm -f) when public headers change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread Panu Matilainen
One more tweak: testing for empty hdrs only actually makes sense for the case where we do our own dbMatch(), which makes the whole thing a little more obvious again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Panu Matilainen
I'm starting to think we might actually be better off without sending notifications for individual packages, because this will be noisy, and doubly so since the psm hooks can get called multiple times per package as you noted. Just announce that transaction is in progress and when it ends.

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread Florian Festi
Merged #1251 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1251#event-3406472496___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-04 Thread Panu Matilainen
Yup, thinking this some more, we don't want to spam the bus with stuff that most likely nobody will care about. There probably are some things we can announce (beginning and end of transactions maybe) but IIRC/AIUI for most part dbus should be about subscriptions. My memories on this front are

[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Florian Festi
The plugin announces start and completion of transactions and the installation and erasure of packages. The patch still needs some polishing: * Names of the DBus enities may need a second thought * Man page is still missing a description of the dbus signal sent * DBus config is not properly

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Florian Festi
Yeah, I had the package info as a separate patch, but I figured it'd be easier to just delete the functions than splitting all the changes and fixes. Otoh I could imaging some GUI tool to not blocking it's UI completely on an running transaction but instead just changing package by package. --

Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-04 Thread Panu Matilainen
On a side-note, this whole thing once again makes me think that we really should have a proper DBUS API for rpm. Yet another thing we should've had ten years ago already. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpm --eval "%{lua:rpm.interactive()}" does not immediately print the output (#1215)

2020-06-04 Thread Miro HronĨok
My script doesn't seem to see system defined macros. Do I need to call something explicitly to load them? ``` $ rpmlua RPM Interactive Lua 5.3 Interpreter > print(rpm.expand("%python3")) %python3 > rpm.define("test b") > print(rpm.expand("%test")) b > $ rpm --eval "%{lua:rpm.interactive()}"

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Panu Matilainen
...noisy and like you said in the ticket, we don't want people to start building their own triggers outside rpm. Information about the contents of a transaction in progress is probably best limited to the invoking process. -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread lgtm-com[bot]
This pull request **fixes 1 alert** when merging d3b5712847684c94474c8573f143d619451fcea3 into 869a36c17224ada40614639f1c12345bfc748663 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-49a6843de6d74ec491c6babb53b48b1784a3504f) **fixed alerts:** * 1 for

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread Panu Matilainen
Okay, maybe third time's the charm... now with iterators specifically handled etc, it looks kinda nicer too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread lgtm-com[bot]
This pull request **fixes 1 alert** when merging de6b3a0b953e3899e3f395e76d59090227fb8e46 into 869a36c17224ada40614639f1c12345bfc748663 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-e42ccade4ef9b03c99c8b59a08045eb1ea2b1896) **fixed alerts:** * 1 for

Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-04 Thread Florian Festi
Well, DBus is not the same as DBus. There are two things you can do there: This thing here is just sending signals. They go to the bus and are then relayed to everyone subscribing to them. I don't know that much about DBus but I would hope sending a few thousands signals shouldn't hurt anyone.