[Rpm-maint] [rpm-software-management/rpm] Output of Lua code truncated after NUL character (#1437)

2020-11-15 Thread Demi Marie Obenour
`%{lua:print "\0a"}` expands to the empty string, which is almost certainly not what the programmer intended. Since NUL characters aren’t allowed in macro expansions, RPM should emit an error in this case. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Distinguish files from directories in src list file (#1436)

2020-11-15 Thread Vitalio
Mark, > BTW. How does this help you speed things up? We do just `grep -v '/$' to filter directories from source list[1], instead of loop similar to `while read f; do test -d $f || echo $f; done` which takes more than 15 seconds on kernel package. Thanks, [1]

[Rpm-maint] [rpm-software-management/rpm] \x1a (ASCII unit separator) cannot be escaped (#1438)

2020-11-15 Thread Demi Marie Obenour
Right now, I cannot write a Lua function `quote_array` that converts an array of strings to a string that (when used as the argument to a macro) will be interpreted as the initial array. This is because \\x1a (ASCII unit separator) cannot be escaped. One solution would be to allow \\x1a to be

[Rpm-maint] [rpm-software-management/rpm] %{**} loses whitespace (#1439)

2020-11-15 Thread Demi Marie Obenour
If a macro is passed several arguments separated by some whitespace, I expect that `%{**}` includes the original whitespace. Instead, this whitespace is lost. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: script plugin API (#1377)

2020-11-15 Thread Demi Marie Obenour
We can vastly expand what can be done from Lua by using LuaJIT and its fantastic FFI. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)

2020-11-15 Thread Vitalio
No need to call edit_dwarf2() if debugedit is invoked just to extract build-id (with `-i -n). Otherwise, we will get `DWARF version 0 unhandled warning for compressed .debug files: /usr/lib/rpm/debugedit: ./usr/lib/debug/...e.ko.debug: DWARF version 0 unhandled Context: We have kernel modules

[Rpm-maint] [rpm-software-management/rpm] debugedit: Distinguish files from directories in src list file (#1436)

2020-11-15 Thread Vitalio
Append / to directories in source file list (for `-l option) to allow quickly distinguish them from regular files (to avoid adding them raw into %files section). This is needed for ALT for our debuginfo processing to speed things up. Co-authored-by: Dmitry V. Levin l...@altlinux.org @ldv-alt

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)

2020-11-15 Thread Mark Wielaard
On Sun, Nov 15, 2020 at 07:11:02AM -0800, Vitalio wrote: > No need to call edit_dwarf2() if debugedit is invoked just to extract > build-id (with `-i -n). Yes, but you also have to check base_dir && dest_dir aren't set. > Otherwise, we will get `DWARF version 0 > unhandled warning for compressed

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Distinguish files from directories in src list file (#1436)

2020-11-15 Thread Mark Wielaard
Hi, On Sun, 2020-11-15 at 07:20 -0800, Vitalio wrote: > Append / to directories in source file list (for `-l > option) to allow > quickly distinguish them from regular files (to avoid adding them raw > into %files section). This is needed for ALT for our debuginfo > processing to speed things up.