Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)

2021-04-28 Thread Panu Matilainen
No you wouldn't. Nobody expects contents of a #-commented line to affect anything coming after it, it's just absurd. It's absurd in specs too as indicated by the endless bugs and tickets filed on the behavior over the years, but at least there we have an excuse or two, and other options (%dnl).

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)

2021-04-28 Thread Panu Matilainen
Just noting that there's significant overlap with #1038 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)

2021-04-28 Thread Demi Marie Obenour
> No you wouldn't. Nobody expects contents of a #-commented line to affect > anything coming after it, it's just absurd. It's absurd in specs too as > indicated by the endless bugs and tickets filed on the behavior over the > years, but at least there we have an excuse or two, and other options

[Rpm-maint] [rpm-software-management/rpm] Ignore comment line contents in macro files (#1659) (#1661)

2021-04-28 Thread Panu Matilainen
Previously %{ and similar in macro file comment line would cause the line continuation logic to trigger and silently eat macro definitions up to the next empty line. Since 75275a87cff04da65d3557f2c40ea2b526528c4c we permit empty lines inside macro definitions, which would cause the whole remaining

Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)

2021-04-28 Thread Panu Matilainen
@mlschroe , I went ahead and created a PR from this with a testcase, hope you don't mind. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Cross build macro confusion (#1650)

2021-04-28 Thread Panu Matilainen
Oh and see also #103 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1650#issuecomment-828286671___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)

2021-04-28 Thread benierc
dlopen load plugins LIBRARY with RTLD_LAZY flag it means the symbols are loaded when references are executed so it causes issue when some references are the same than in system append RTLD_BINDDEEP allows to first load symbols from the plugin library You can view, comment on, or merge this pull

[Rpm-maint] [rpm-software-management/rpm] Plugin library symbols are not loaded at first (#1663)

2021-04-28 Thread benierc
dlopen load plugins LIBRARY with RTLD_LAZY flag it means the symbols are loaded when references are executed so it causes issue when some references are the same than in system

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-28 Thread Christopher Yeleighton
@yecril71pl pushed 1 commit. 160eff4a51aee381fb90ea9105064e6647cc706a EXTRA_DIST = README.md -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)

2021-04-28 Thread ニール・ゴンパ
Yep, I worked on #1038 to solve this and several other problems I was having in OpenMandriva. Alas, it's stuck for now.  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

2021-04-28 Thread ニール・ゴンパ
@pmatilai Personally, I'd also like a solution to an annoying case that I have on macOS where I have binaries with multiple architectures in them. What you're saying here could probably be expanded to handle that too, I suppose, since it essentially turns architectures into qualifiers for

Re: [Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)

2021-04-28 Thread Florian Festi
I understand the issue of symbols of the plugin vs system symbols as both may be linked to different versions of a library or symbols may collide otherwise. I am just not quite sure how or if at all this relates to RTLD_LAZY vs RTLD_NOW. So while the change may be OK I wonder if the commit

Re: [Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)

2021-04-28 Thread benierc
@ffesti, i see what you mean, i will change it, thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)

2021-04-28 Thread susematz
Wow, looks really similar indeed. It was a result of a specific local project and I didn't know about #1038, so let that be an indication that something like this would be _really_ welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-28 Thread Florian Festi
Looks like the new file does not get automatically picked up by automake and needs to be added to `EXTRA_DIST` in `tests/Makefile.am`. Generally changes to the content (even if just rewording) and changing the format as a whole should be done in separate patches but it's not a big deal here.

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-28 Thread Florian Festi
Oh, and thanks for the patch! Your attention to details like this is appreciated! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: