Closed #297 via 3684424fe297c996bb05bb64631336fa2903df12.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ignatenkobrain commented on this pull request.
> @@ -351,6 +351,9 @@ int rpmFileIsCompressed(const char * file,
> rpmCompressedMagic * compressed)
(magic[4] == 0x5a) && (magic[5] == 0x00)) {
/* new style xz (lzma) with magic */
*compressed = COMPRESSED_XZ;
+}
ignatenkobrain commented on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
this is mostly if you would like to do `pkg-config --static --cflags --ldflags
rpm` to link
ignatenkobrain commented on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
well, we do for Libraries.private... but since we use pkg-config for zstd, it
is better to put
Conan-Kudo requested changes on this pull request.
> @@ -8,7 +8,7 @@ Name: RPM
Description: RPM Package Manager
Version: @VERSION@
URL: http://rpm.org
-# Requires:
+Requires.private: @ZSTD_REQUIRES@
If this is linked in from librpmio, there's no reason to add
`Requires.private`, right? We
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/297
-- Commit Summary --
* add support for zstd compressed payload
* ci: Add libzstd-devel to CI Dockerfile
-- File Changes --
M build/pack.c (6)
M
