Re: [Rpm-maint] [rpm-software-management/rpm] legacy.c: Fix headerGetEntry count (#399)

2018-02-26 Thread Panu Matilainen
Merged #399. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/399#event-1491825991___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] legacy.c: Fix headerGetEntry count (#399)

2018-02-26 Thread Panu Matilainen
It's indeed a bit late to be fixing code that was deprecated ten years ago and since then actually removed, but whatever, I've no reason not to include it either. Thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it o

Re: [Rpm-maint] [rpm-software-management/rpm] legacy.c: Fix headerGetEntry count (#399)

2018-02-23 Thread Igor Gnatenko
ignatenkobrain approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/399#pullrequestreview-99049498___

Re: [Rpm-maint] [rpm-software-management/rpm] legacy.c: Fix headerGetEntry count (#399)

2018-02-23 Thread Alexey Tourbin
The following code used to work with rpm-4.0. ```c static int getFileCount(Header h) { int count; int ret = headerGetEntry(h, RPMTAG_BASENAMES, NULL, NULL, &count); return ret == 1 ? count : 0; } ``` -- You are receiving this because you are subscribed to this thread. Reply to this email

[Rpm-maint] [rpm-software-management/rpm] legacy.c: Fix headerGetEntry count (#399)

2018-02-23 Thread Alexey Tourbin
rpmtdFreeData resets td.count to 0, so the whole thing never worked. Better late than never, they say. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/399 -- Commit Summary -- * legacy.c: Fix headerGetEntry count -- File Ch