Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-15 Thread Panu Matilainen
Merged #1464 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#event-4211091180___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-15 Thread Panu Matilainen
BTW thanks for the review @Conan-Kudo - I know this is far from complete and 
all, but in order to get anywhere with the docs we need to keep the bar 
relatively low.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#issuecomment-760932999___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+As a special case, `BuildArch: noarch` can be used on sub-package
+level to allow eg. documentation of otherwise arch-specific package
+to be shared across multiple architectures.
+
+ Prefixes
+
+Specify prefixes this package may be installed into, used to make
+packages relocatable. Very few packages are.
+
+ Docdir
+
+Declare a non-default documentation directory for the package.
+Usually not needed.
+
+ Removepathpostfixes

That question is outside the scope here, but I fail to see how adding yet 
another alias would make it somehow better, it's just more crud that will 
confuse people because they end up thinking maybe its something different as 
the old version didn't support this but supports that etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#discussion_r555037323___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request.



> +
+As a special case, `BuildArch: noarch` can be used on sub-package
+level to allow eg. documentation of otherwise arch-specific package
+to be shared across multiple architectures.
+
+ Prefixes
+
+Specify prefixes this package may be installed into, used to make
+packages relocatable. Very few packages are.
+
+ Docdir
+
+Declare a non-default documentation directory for the package.
+Usually not needed.
+
+ Removepathpostfixes

Yeah, I wish I had realized `Postfix` -> `Suffix` back when this was being 
made. Could we add an alias for it, then?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#discussion_r555026792___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +Specifies the architecture which the resulting binary package
+will run on.  Typically this is a CPU architecture like sparc,
+i386. The string 'noarch' is reserved for specifying that the
+resulting binary package is platform independent.  Typical platform
+independent packages are html, perl, python, java, and ps packages.
+
+As a special case, `BuildArch: noarch` can be used on sub-package
+level to allow eg. documentation of otherwise arch-specific package
+to be shared across multiple architectures.
+
+ Prefixes
+
+Specify prefixes this package may be installed into, used to make
+packages relocatable. Very few packages are.
+
+ Docdir

https://github.com/rpm-software-management/rpm/blob/5ce2b5e3121aa07eb1ccf2bc24443c1536bf94d5/build/parsePreamble.c#L833

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#discussion_r555019926___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
Not that rpm cares about the case (it doesn't) but adjusted to the commonly 
used casing now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#issuecomment-757925536___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
@pmatilai pushed 1 commit.

00283b1e079bd3b04dca8b811de61a9dc70a52c9  fixup! Add bunch of docs on spec tags 
and file virtual attributes


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464/files/a062894c1be6e463b4bb1e24f88698b4143b3650..00283b1e079bd3b04dca8b811de61a9dc70a52c9
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+ Exclusivearch
+
+Package is only buildable on architectures listed here.
+For example, it's probably not possible to build an i386-specific BIOS
+utility on ARM, and even if it was it probably would not make any sense.
+
+ Excludeos
+
+Package is not buildable on specific OS'es listed here.
+
+ Exclusiveos
+
+Package is only buildable on OS'es listed here.
+
+ Buildarchs

Right, either `BuildArch` or `BuildArchitectures`, but not `BuildArchs`...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#discussion_r555013799___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2021-01-11 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+Package is only buildable on OS'es listed here.
+
+ Buildarchs
+
+Specifies the architecture which the resulting binary package
+will run on.  Typically this is a CPU architecture like sparc,
+i386. The string 'noarch' is reserved for specifying that the
+resulting binary package is platform independent.  Typical platform
+independent packages are html, perl, python, java, and ps packages.
+
+As a special case, `BuildArch: noarch` can be used on sub-package
+level to allow eg. documentation of otherwise arch-specific package
+to be shared across multiple architectures.
+
+ Prefixes

Oh but we do. "Prefix" is the deprecated version that is merely an alias to 
Prefixes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1464#discussion_r555012970___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add bunch of docs on spec tags and file virtual attributes (#1464)

2020-12-24 Thread ニール・ゴンパ
@Conan-Kudo requested changes on this pull request.

Lots of tag capitalization, but also a couple of other minor things...

> + Nosource
+ Nopatch

These should be "cased" correctly as `NoSource` and `NoPatch` (also, we have a 
`NoPatch`?!?)

> @@ -167,7 +179,109 @@ The end result of all this, though, is that you can't 
> rebuild
 ``no-source'' RPM packages using `rpm --rebuild' unless you also have
 the sources or patches which are not included in the .nosrc.rpm.
 
-### BuildRequires: Tag
+ Url

`Url` -> `URL`

> @@ -167,7 +179,109 @@ The end result of all this, though, is that you can't 
> rebuild
 ``no-source'' RPM packages using `rpm --rebuild' unless you also have
 the sources or patches which are not included in the .nosrc.rpm.
 
-### BuildRequires: Tag
+ Url
+
+URL supplying further information about the package, typically upstream
+website.
+
+ Bugurl

`Bugurl` -> `BugURL`

> @@ -167,7 +179,109 @@ The end result of all this, though, is that you can't 
> rebuild
 ``no-source'' RPM packages using `rpm --rebuild' unless you also have
 the sources or patches which are not included in the .nosrc.rpm.
 
-### BuildRequires: Tag
+ Url
+
+URL supplying further information about the package, typically upstream
+website.
+
+ Bugurl
+
+Bug reporting URL for the package.
+
+ Modularitylabel

`Modularitylabel` -> `ModularityLabel`

> @@ -167,7 +179,109 @@ The end result of all this, though, is that you can't 
> rebuild
 ``no-source'' RPM packages using `rpm --rebuild' unless you also have
 the sources or patches which are not included in the .nosrc.rpm.
 
-### BuildRequires: Tag
+ Url
+
+URL supplying further information about the package, typically upstream
+website.
+
+ Bugurl
+
+Bug reporting URL for the package.
+
+ Modularitylabel
+ Disttag

`Disttag` -> `DistTag`

> @@ -167,7 +179,109 @@ The end result of all this, though, is that you can't 
> rebuild
 ``no-source'' RPM packages using `rpm --rebuild' unless you also have
 the sources or patches which are not included in the .nosrc.rpm.
 
-### BuildRequires: Tag
+ Url
+
+URL supplying further information about the package, typically upstream
+website.
+
+ Bugurl
+
+Bug reporting URL for the package.
+
+ Modularitylabel
+ Disttag
+ Vcs

`Vcs` -> `VCS`

> + Bugurl
+
+Bug reporting URL for the package.
+
+ Modularitylabel
+ Disttag
+ Vcs
+
+ Distribution
+ Vendor
+ Packager
+
+Optional package distribution/vendor/maintainer name / contact information.
+Rarely used in specs, typically filled in by buildsystem macros.
+
+ Buildroot

`Buildroot` -> `BuildRoot`

> + Autoreqprov
+ Autoreq
+ Autoprov

* `Autoreqprov` -> `AutoReqProv`
* `Autoreq` -> `AutoReq`
* `Autoprov` -> `AutoProv`

> + Conflicts
+
+Capabilities this package conflicts with, typically packages with
+conflicting paths or otherwise conflicting functionality.
+
+ Obsoletes
+
+Packages obsoleted by this package. Used for replacing and renaming
+packages.
+
+ Recommends
+ Suggests
+ Supplements
+ Enhances
+
+ OrderByRequires

Isn't this `OrderWithRequires`?

> +Capabilities this package conflicts with, typically packages with
+conflicting paths or otherwise conflicting functionality.
+
+ Obsoletes
+
+Packages obsoleted by this package. Used for replacing and renaming
+packages.
+
+ Recommends
+ Suggests
+ Supplements
+ Enhances
+
+ OrderByRequires
+
+ Prereq

`Prereq` -> `PreReq`

> +
+Packages obsoleted by this package. Used for replacing and renaming
+packages.
+
+ Recommends
+ Suggests
+ Supplements
+ Enhances
+
+ OrderByRequires
+
+ Prereq
+
+Obsolete, do not use.
+
+ Buildprereq

`Buildprereq` -> `BuildPreReq`

> + Recommends
+ Suggests
+ Supplements
+ Enhances
+
+ OrderByRequires
+
+ Prereq
+
+Obsolete, do not use.
+
+ Buildprereq
+
+Obsolete, do not use.
+
+ Buildrequires

`Buildrequires` -> `BuildRequires`

> @@ -189,12 +303,81 @@ the libraries to access an ext2 file system, you could 
> express this as
BuildRequires: e2fsprofs-devel = 1.17-1
 ```
 
-Finally, if your package used C++ and could not be built with gcc-2.7.2.1, you
-can express this as
+ Buildconflicts

`Buildconflicts` -> `BuildConflicts`

>  ```
 
+ Excludearch

`Excludearch` -> `ExcludeArch`

>  ```
 
+ Excludearch
+
+Package is not buildable on architectures listed here.
+Used when software is portable across most architectures except some,
+for example due to endianess issues.
+
+ Exclusivearch

`Exclusivearch` -> `ExclusiveArch`

>  ```
 
+ Excludearch
+
+Package is not buildable on architectures listed here.
+Used when software is portable across most architectures except some,
+for example due to endianess issues.
+
+ Exclusivearch
+
+Package is only buildable on architectures listed here.
+For example, it's probably not possible to build an i386-specific BIOS