Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging f6f668636bb60736d17b0b51a66d09eb71d5c780 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-3c2ebb1d32808855e96583b79f1dea32188667d1) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603897910___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 5 commits. bda2ab8f474bbb1ff6e094e3d6d00bee7f26d025 Add a "ci" make target for easy local running e3022bf6efb437124930f972dff24f1b34355d48 Enable all our configure options during distcheck for maximum coverage 117d4f8a2e5d47eba59d8942b6a8c41fef7b9a8d Don't allow test-suite failures inside distcheck either 5f08ccd502849e4969f24667095fa4c8e26c1a3a Fix defunct gpg-agents lingering around after test-suite f6f668636bb60736d17b0b51a66d09eb71d5c780 Run full distcheck as the CI test for wider coverage -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/abe76ce9b729cb58a77819050c26e8893a9f8167..f6f668636bb60736d17b0b51a66d09eb71d5c780 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging abe76ce9b729cb58a77819050c26e8893a9f8167 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-86872a1510ecbed302209c3c50eb6541fd5e49f0) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603850810___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 1 commit. abe76ce9b729cb58a77819050c26e8893a9f8167 Run CI as parallel build to maximum available CPUs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/a30a6b88c3932389785fe8f738cfb6d6225d2b22..abe76ce9b729cb58a77819050c26e8893a9f8167 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
> Use make check instead of make distcheck in CI Eek, no to this! distcheck is a really, really powerful tool for ensuring the resulting tarball is good to go. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603844257___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging a30a6b88c3932389785fe8f738cfb6d6225d2b22 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-847ee207d24d24ed58731505a0595166bfe7c246) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603843736___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 1 commit. a30a6b88c3932389785fe8f738cfb6d6225d2b22 Use make check instead of make distcheck in CI -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/d43d788fe610ad437ad55cc4972dd8025a37ab93..a30a6b88c3932389785fe8f738cfb6d6225d2b22 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging d43d788fe610ad437ad55cc4972dd8025a37ab93 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-12d7209b764aefd4eaeba76c5200d40f3a0c92c5) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603831780___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 3 commits. a58003116528a555e5bb0e6f58347fb0d0a7ca1e Set rpm-maint list as the CI Dockerfile maintainer f8017643152b4586501c61ee65f8b4f699551faa Hardwire the Fedora version used for CI d43d788fe610ad437ad55cc4972dd8025a37ab93 Run CI as parallel build to maximum available CPUs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/a2576ab6fe8676cd9b15a3836590069b21d80713..d43d788fe610ad437ad55cc4972dd8025a37ab93 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
We'll want to lock the Fedora version in CI to avoid the likes of the Python mess in case we ever need to do another 4.14.x release, but other than that I think this is good to go now. It's an RC afterall so there is still a chance to fix if something breaks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603791742___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging a2576ab6fe8676cd9b15a3836590069b21d80713 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-ddb4e54a84b9df329c644492b1256d7b6550da5f) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603168720___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 2 commits. f5464cd88bbd6ce6315d4081953382fa6dc3c84b CI Dockerfile: Move copy command to a later time a2576ab6fe8676cd9b15a3836590069b21d80713 CI: enbale Python bindings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/48ee0c3ad781e2686cbc3cca5341443322cb3e5f..a2576ab6fe8676cd9b15a3836590069b21d80713 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging 48ee0c3ad781e2686cbc3cca5341443322cb3e5f into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-f6f7bf051c077acd3fc3b1f8981a30c22997b4fe) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-603084130___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 1 commit. 48ee0c3ad781e2686cbc3cca5341443322cb3e5f Add python2-devel to CI root -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/d697e9203b7e9a137febe2a29aaf99adb4ed84c4..48ee0c3ad781e2686cbc3cca5341443322cb3e5f ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging d697e9203b7e9a137febe2a29aaf99adb4ed84c4 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-78507ce5040c3795798c34f8dfbb5587f97dc9b5) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-602922600___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging 56de48c00912cb5eec276721a1ee87b8d1d97975 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-5e7a927b23b9fa2362cbb597d2048ad589fdd4d6) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-602905486___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging f82ee9df748944a31128de97c7b4927a7c938734 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-616778c78f8fc978fd3bd0c93222f4df6c8b68f9) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-602900758___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti pushed 3 commits. 96f75d58e5c8855af4583a69a1fa67b3bdbbacbc Use python2 as the python binary name 0c5940ef1859ea9bbb32781825d8771a2bba2d02 Unbreak testsuite from unversioned obsoletes warnings 966ac68a35fb1d69a7684904844525b8e49bcae9 Move version to 4.14.3-rc1 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078/files/59ce0dba6a3d68e5bf6f0168ba17cc8b7c8999e1..966ac68a35fb1d69a7684904844525b8e49bcae9 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
Okay, actually "distro buy-in" would the more appropriate expression. Community is upstreams, where it was largely dealt with. But distros who expect a stable branch to stay like it is are quite a different thing, stable branch updates are not supposed to do such things. So explicit "please include the Python 3 string change" requests from distro people would go a long way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-595204174___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@pmatilai The reality is, we already dealt with it and "fixed" it because you forced the issue. At this point, "community buy-in" happened because you made us do it. What more do you want? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-595200721___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
Yup. With RHEL we had no choice really, and in Fedora it was a canary for soon-to-land 4.15. With other users we don't know and can't control In many ways the sanest option would be to pull those string changes to 4.14 too, and declare it a bug fix. But we'd need a community buy-in for such a change upstream. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-595200048___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@pmatilai Well, you did it in Fedora and RHEL with RPM 4.14, so... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-595184340___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
Oh, I thought /usr/bin/python is still Python 2 on Fedora 32 but that's not the case, the CI needs to be tweaked to use python2 explicitly. Getting Python 3 to pass would require pulling in the bytes -> strings change. Which would be a controversial thing to do... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-593795775___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
I wonder if it really is worth getting the Python test suite to pass on Python3. rpm-4.14 did only run the test suite on Python 2 and I don't really see the transition to Python3 as part of this update. May be the easier way is to hard code the CI to use an older Fedora release which still includes Python 2 - as logn as this still lasts... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-593511659___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging 59ce0dba6a3d68e5bf6f0168ba17cc8b7c8999e1 into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-06a7fb81f09788d5dee4cccfef67147f04e02d94) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-593487464___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@mlschroe Are there patches SUSE has been backporting for SLE 15 that should be included in here for 4.14.3? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-590018118___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
Also as a reminder to us all, the final commit with version update is missing here, and along with that, rpm_version_info needs to be updated. There's at least one new API added so that needs to be reflected as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-588135289___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
Looking at the semaphoreci failure, there's a bunch of these: > +++ /opt/rpm/tests/rpmtests.dir/at-groups/443/stderr 2020-02-18 > 07:51:48.219806927 + > @@ -0,0 +1 @@ > +/opt/rpm/tests/rpmtests.dir/at-groups/443/test-source: line 48: python: > command not found Pulling commit d15ea79139304e14e6aaf6143af34c0405c41966 should minimally fix that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-588131906___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
@ffesti one another thing which needs to be backported is definitely 15b296c324794d288750136b3b4f3350c3d0b8c7 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-587333931___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] First iteration of a 4.14.3 update release (#1078)
This pull request **fixes 1 alert** when merging 025537a689d8016d086935afda82266c3fa0199c into 4a9440006398646583f0d9ae1837dad2875013aa - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-dca2d891d691d6eba68127307abea1cabcc8d08c) **fixed alerts:** * 1 for FIXME comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1078#issuecomment-587328617___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
