Thanks of the effort!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#issuecomment-246329016___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Merged #17.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#event-785843506___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Looks good to me!
@ffesti What do you think?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#issuecomment-245801457___
Rpm-maint mailing list
Done, this should hopefully suffice. :)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#issuecomment-245781671___
Rpm-maint mailing list
I'd squash the last 5 patches together and put them on to of the current HEAD
if this is ok with you.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
@ffesti @ignatenkobrain Anyone have a chance to re-review after the rebase?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
sorry for slooow response, but rebased now :)
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#issuecomment-222306973___
Rpm-maint mailing list
Hm, there's several asserts in place throughout source code that would be bad
to compile with -DNDEBUG as the desired and safe behaviour expected for assert
is to abort if expession evaluated is false...
Of course one could replace the assert(3) with:
if(--mt_options.threads == 0)
abort();
Can one of the admins verify this patch?
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/17#issuecomment-219041050___
Rpm-maint mailing list
