Merged #1527 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#event-4308766395___
Rpm-maint mailing list
Okay so nobody objects, even remotely, to the actual change. Except for myself,
for whom this will make bisecting old stuff somewhat more difficult, but then
ability to disable Lua only helps if the thing to bisect is not Lua. There's a
price to everything, shrug.
--
You are receiving this
Spelling fixed...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775745577___
Rpm-maint mailing list
Nah, this makes a ton of sense to do. At some point, I need to figure out how
to do Lua for debbuild too. I just don't know how I'll square that with how
Debian package scripts work...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Right, I have to say I seem to have forgotten that particular nuance of the
English language. Will fix, but I have to say I was expecting somewhat more
fundamental discussion over this matter :laughing:
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@pmatilai small nit of the commit message: "practise" -> "practice" (en-gb has
the former for verb, but you're not using it that way, and en-us doesn't have
that spelling at all).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-585536561___
@pmatilai commented on this pull request.
> @@ -5,8 +5,8 @@ EXTRA_DIST = \
AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS =
@pmatilai pushed 1 commit.
fda8abbecbaea8b47d015b48d833be45fe0ec9e7 Make Lua a hard requirement for rpm
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@pmatilai commented on this pull request.
> @@ -5,8 +5,8 @@ EXTRA_DIST = \
AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS =
@mlschroe commented on this pull request.
> @@ -5,8 +5,8 @@ EXTRA_DIST = \
AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS =
@Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-583694750___
@pmatilai pushed 1 commit.
f56e52d1b1fea74a147e5032ec7019a9d771c442 Make Lua a hard requirement for rpm
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
13 matches
Mail list logo
