Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
Merged #1527 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#event-4308766395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
Okay so nobody objects, even remotely, to the actual change. Except for myself, for whom this will make bisecting old stuff somewhat more difficult, but then ability to disable Lua only helps if the thing to bisect is not Lua. There's a price to everything, shrug. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775885801___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
Spelling fixed... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775745577___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
Nah, this makes a ton of sense to do. At some point, I need to figure out how to do Lua for debbuild too. I just don't know how I'll square that with how Debian package scripts work... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775190176___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
Right, I have to say I seem to have forgotten that particular nuance of the English language. Will fix, but I have to say I was expecting somewhat more fundamental discussion over this matter :laughing: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775187900___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@pmatilai small nit of the commit message: "practise" -> "practice" (en-gb has the former for verb, but you're not using it that way, and en-us doesn't have that spelling at all). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775177695___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-585536561___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@pmatilai commented on this pull request. > @@ -5,8 +5,8 @@ EXTRA_DIST = \ AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I. -libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@ -libluaext_la_LIBADD = @LUA_LIBS@ +libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS) +libluaext_la_LIBADD = $(LUA_LIBS) libluaext_la_SOURCES = \ This change dropped in the last push. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#discussion_r571829890___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@pmatilai pushed 1 commit. fda8abbecbaea8b47d015b48d833be45fe0ec9e7 Make Lua a hard requirement for rpm -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527/files/f56e52d1b1fea74a147e5032ec7019a9d771c442..fda8abbecbaea8b47d015b48d833be45fe0ec9e7 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@pmatilai commented on this pull request. > @@ -5,8 +5,8 @@ EXTRA_DIST = \ AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I. -libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@ -libluaext_la_LIBADD = @LUA_LIBS@ +libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS) +libluaext_la_LIBADD = $(LUA_LIBS) libluaext_la_SOURCES = \ Oh, good catch. I initially looked at going the ZSTD-route, but then switched back but this one case was left behind. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#discussion_r571808448___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@mlschroe commented on this pull request. > @@ -5,8 +5,8 @@ EXTRA_DIST = \ AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I. -libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@ -libluaext_la_LIBADD = @LUA_LIBS@ +libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS) +libluaext_la_LIBADD = $(LUA_LIBS) libluaext_la_SOURCES = \ What's with this change? The rest of the code still uses the @LUA_XXX@ syntax, so why is this done here? (ZSTD_XXX is the other odd candidate here) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-584464103___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-583694750___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)
@pmatilai pushed 1 commit. f56e52d1b1fea74a147e5032ec7019a9d771c442 Make Lua a hard requirement for rpm -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1527/files/cba7240e327714733833eeb27b5f5cb66b8b1545..f56e52d1b1fea74a147e5032ec7019a9d771c442 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
