Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Florian Festi
Merged #3476 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476#event-15467041671
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Panu Matilainen
@pmatilai pushed 2 commits.

bafe11432c1bdfe08f5710d69600c44385ade6d7  Sanitize %__foo_sign_cmd macros
ce032dee9f8e07cd297b3bc34577efa832faad1d  Make the signing macros parametric

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476/files/6db4c9c449a5270fc55d1012e3e65a66d8622ee6..ce032dee9f8e07cd297b3bc34577efa832faad1d
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Florian Festi
Reviewed and merged #3477.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476#issuecomment-2506326787
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Panu Matilainen
FWIW, the first patch in this series inspired me to whip up 
https://github.com/rpm-software-management/rpm/pull/3477, so actually I'd 
prefer to get that merged first and then rebase this on top.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476#issuecomment-2506307443
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Florian Festi
Looks good to me. Can you please rebase and then merge?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476#issuecomment-2506273332
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Panu Matilainen
@pmatilai pushed 3 commits.

03448bc91b818d15623c408c1f3d24a185980336  Make expand_this() take C++ string as 
the name argument
68384826a6c05ac015ee77ca6479de807b19d2e7  Sanitize %__foo_sign_cmd macros
6db4c9c449a5270fc55d1012e3e65a66d8622ee6  Make the signing macros parametric

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476/files/b8363536ef08a4d3df9f482707504d41dc6e9ef1..6db4c9c449a5270fc55d1012e3e65a66d8622ee6
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the signing macros parametric (PR #3476)

2024-11-28 Thread Panu Matilainen
Eh, completely forgot we do now have a C++ variant for rpmExpandThisMacro() too 
:facepalm: :laughing: 
I'll update it to use that instead...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476#issuecomment-2505859036
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint