Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Merged #1009 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950342476___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Right, I hate these unsilenceable "we know better" warnings too, with a passion. BTW thanks for the pointer, at least in the newer bug points out there's now a "nodiscard" attribute that does the right thing for these cases. Guess we should lobby glibc to adopt that instead of the obnoxious warn_unused_result. Anyway, works for me, thanks for fixing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#issuecomment-574604640___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Reopened #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950287205___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
@mlschroe pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009/files/9076d958bf91502eed454283d7daeafece4c6836..471e7d8bb26f0d7be877a261812b8dd8172650d3 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Oh my. The gcc people seem to be not too happy about this, but it's hard to fix because the void cast is optimized away before the unused result check is done. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 Anyway, fixed to something that will work with the current gcc version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#issuecomment-574596279___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
pmatilai requested changes on this pull request. As per above: this doesn't actually change the behavior at all, so NAK. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#pullrequestreview-343075223___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Casting doesn't silence warnings from functions with warn_unused_result attribute. You need to actually check the value. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#issuecomment-574518207___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
