http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Conrad Meyer kon...@tylerc.org changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #10 from Kevin Kofler kevin.kof...@chello.at 2008-12-17 09:44:00
---
I'd even say abuse of %{name} can be outright harmful, for example using it in
the URL tag means you can't just paste the URL into a browser. And it usually
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #12 from Conrad Meyer kon...@tylerc.org 2008-12-17 11:23:14 ---
http://konradm.fedorapeople.org/fedora/SPECS/cmus.spec
http://konradm.fedorapeople.org/fedora/SRPMS/cmus-2.2.0-3.fc9.src.rpm
Sorry it took so long.
--
Configure
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
CC||musur...@gmail.com
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #14 from Conrad Meyer kon...@tylerc.org 2008-12-17 11:44:05 ---
Actually I didn't have to patch the makefile at all. Just passed V=2.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #11 from Andrea Musuruane musur...@gmail.com 2008-12-17 11:12:04
---
(In reply to comment #9)
Using %{name} and %{version} macros is not mandated. I use %{version} macros,
but prefer not to use %{name} especially when %{name}
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
Blocks|3 |4
--- Comment
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
AssignedTo|rpmfusion-package- |musur...@gmail.com
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #16 from Andrea Musuruane musur...@gmail.com 2008-12-17 16:34:28
---
Can you return the favour and do a review? I have #476357 in Fedora ;)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
---
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #13 from Andrea Musuruane musur...@gmail.com 2008-12-17 11:35:00
---
(In reply to comment #8)
* There is no compile output. Makefile must be patched to see it. This is a
blocking issue. A reviewer must see the output of what
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #17 from Kevin Kofler kevin.kof...@chello.at 2008-12-17 23:29:39
---
Probably we have some kind of misunderstanding Kevin. The makefile suppress
the
output when calling many commands including the compiler. In this way
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #5 from Andrea Musuruane musur...@gmail.com 2008-12-16 12:12:35
---
(In reply to comment #4)
Ah, that's a good idea :).
I tried the above and got this in %doc, though:
error: magic_file(ms,
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #7 from Andrea Musuruane musur...@gmail.com 2008-12-16 14:51:23
---
(In reply to comment #6)
OK, I have incorporated your suggestions into this set of spec/srpm:
http://konradm.fedorapeople.org/fedora/SPECS/cmus.spec
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #6 from Conrad Meyer kon...@tylerc.org 2008-12-16 12:41:31 ---
OK, I have incorporated your suggestions into this set of spec/srpm:
http://konradm.fedorapeople.org/fedora/SPECS/cmus.spec
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #8 from Kevin Kofler kevin.kof...@chello.at 2008-12-17 02:38:28
---
* There is no compile output. Makefile must be patched to see it. This is a
blocking issue. A reviewer must see the output of what is happening when
building
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #9 from Conrad Meyer kon...@tylerc.org 2008-12-17 02:49:54 ---
Using %{name} and %{version} macros is not mandated. I use %{version} macros,
but prefer not to use %{name} especially when %{name} is longer than cmus
(what it
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
Summary|cmus - Ncurses-Based Music |Review Request:
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #3 from Andrea Musuruane musur...@gmail.com 2008-12-15 16:41:33
---
Just some questions for now:
* You should really clean up the script. If you don't use patches than do not
include them.
* Why do you do
./configure [..]
http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #4 from Conrad Meyer kon...@tylerc.org 2008-12-15 23:40:15 ---
(In reply to comment #3:)
Just some questions for now:
* You should really clean up the script. If you don't use patches than do
not include them.
OK.
* Why do
20 matches
Mail list logo
