[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@gmail.com
  namespace||free

--- Comment #26 from leigh scott  ---
(In reply to Hans de Goede from comment #14)
> Good:

> - macro use consistent

Don't you mean not used at all?

https://pkgs.rpmfusion.org/cgit/free/game-data-packager.git/commit/?id=611a9aaea9845aad41298ff17261615562e7e995

> Everything looks good to me: Approved.

LOL :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Alexandre Detiste  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #25 from Alexandre Detiste  2016-07-23 
10:08:11 CEST ---
I brutaly disabled .svg support in Rawhide package for now.

These .svg are checked again at runtime
& this application can cope with it.

The packages for F23 & F24 do have .svg support.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #24 from Alexandre Detiste  2016-07-23 
01:47:17 CEST ---
Arrgh, I missed the "%{?dist}" thingie.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #23 from Sérgio Basto  2016-07-23 01:12:26 CEST 
---
(In reply to comment #22)
> $ LANG=C dnf list rfpkg
> Failed to synchronize cache for repo 'rpmfusion-nonfree-updates-testing',
> disabling.
> Last metadata expiration check: 0:04:46 ago on Sat Jul 23 00:56:31 2016.
> Installed Packages
> rfpkg.noarch1.23.3-1.fc25   @rpmfusion-free-rawhide
> Available Packages
> rfpkg.noarch1.23.4-1.fc25   rpmfusion-free-rawhide
> 
> 
> ??? I don't know what the '@' means.

menas that is installed ?!? , so why not dnf update  ? 


> $ sudo dnf install
> http://download1.rpmfusion.org/free/fedora/development/rawhide/Everything/x86_64/os/Packages/r/rfpkg-1.23.4-1.fc25.noarch.rpm
> 
> -> This works.

DEBUG util.py:421:  Error: Package: inkscape-0.92-0.fc25pre1.i686 (build)
DEBUG util.py:421: Requires: libpoppler.so.60

It is building correctly, but rawhide have many broken deps ..., you may
processed, if you want, to f24 . 

Thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #22 from Alexandre Detiste  2016-07-23 
01:05:11 CEST ---
$ LANG=C dnf list rfpkg
Failed to synchronize cache for repo 'rpmfusion-nonfree-updates-testing',
disabling.
Last metadata expiration check: 0:04:46 ago on Sat Jul 23 00:56:31 2016.
Installed Packages
rfpkg.noarch1.23.3-1.fc25   @rpmfusion-free-rawhide
Available Packages
rfpkg.noarch1.23.4-1.fc25   rpmfusion-free-rawhide


??? I don't know what the '@' means.

$ sudo dnf install
http://download1.rpmfusion.org/free/fedora/development/rawhide/Everything/x86_64/os/Packages/r/rfpkg-1.23.4-1.fc25.noarch.rpm

-> This works.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #21 from Sérgio Basto  2016-07-23 00:59:48 CEST 
---
(In reply to comment #20)
> $ rpm -q rfpkg
> rfpkg-1.23.3-1.fc25.noarch

http://koji.rpmfusion.org/koji/buildinfo?buildID=852

rfpkg-1.23.4-1.fc25 kwizart 2016-07-04 20:02:13

you need update to it

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #20 from Alexandre Detiste  2016-07-23 
00:55:21 CEST ---
$ rpm -q rfpkg
rfpkg-1.23.3-1.fc25.noarch

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #19 from Sérgio Basto  2016-07-23 00:46:14 CEST 
---
you need update rfpkg to 1.23.4 , should be already in repos !?!

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Sérgio Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com

--- Comment #17 from Sérgio Basto  2016-07-22 23:24:16 CEST 
---
https://admin.rpmfusion.org/pkgdb/package/free/game-data-packager/

Alexandre Detiste,  now you may commit and build the package on RPMFusion ,
just need follow http://rpmfusion.org/Contributors instructions.

Thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|33  |

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #16 from Alexandre Detiste  2016-01-03 
11:37:35 CET ---
Package CVS request
==
Package Name: game-data-packager
Short Description: Installer for game data files
Owners: adetiste
Branches: F-23
InitialCC:
--
License tag: free

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Alexandre Detiste  changed:

   What|Removed |Added

 Blocks||33

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Hans de Goede  changed:

   What|Removed |Added

 Blocks|3   |4

--- Comment #14 from Hans de Goede  2016-01-02 
12:32:19 CET ---
Good:
=
- rpmlint checks return:
 game-data-packager.src: W: invalid-url Source0:
game-data-packager-20151231.tar.gz
This is normal for a snapshot pkg, ignore
 game-data-packager.noarch: E: zero-length
/etc/game-data-packager/quake3-mirrors
I assume this is intentional and thus can also be ignored ?
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2 and GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime


Everything looks good to me: Approved.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #15 from Alexandre Detiste  2016-01-02 
14:50:19 CET ---
(In reply to comment #14)
> /etc/game-data-packager/quake3-mirrors
> I assume this is intentional and thus can also be ignored ?

That was pre-emptively explained in #0.
(hey, I'm not angry or something ;-) )

I reviewed the git log for this file
and the various mirrors listed there
were taken offline one-by-one :-( ,
but the needed file are still available
on other mirrors. :-)

So that's an "upstream" problem, but I won't edit this
file there just to make rpmlint stop complaining.

I added this to the specfile; but this is not a change
big enough to warrant a new SRPM review:

"find $RPM_BUILD_ROOT/etc/game-data-packager -empty 
 -exec sh -c "echo '# we need more mirrors' > {}" \;"

--

Even more chatter ;-) :

I own two almost-20-years old ISP webpage accounts,
but those are so tiny like 15Mb that I can only
mirror the smallest files.

Or I could mirror some on my Raspeberry Pi "server"
as a last-resort mirror. (I have 100Gb/month)

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787990

There's a mirroring tool in tools/, that
can also check existing files against known hashes.

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/tools/mirror.py

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #12 from Alexandre Detiste  2015-12-31 
11:39:03 CET ---
I now enabled the tests too.

Here's a new SRPM:

https://github.com/a-detiste/fedora/raw/master/game-data-packager-44-0.2.git2015123150f64b6.noarch.rpm

> Be careful with submitting scratch builds of rpmfusion pkgs to
> koji.fedoraproject.org

Ok, I just wanted to build it once in a clean chroot.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #13 from Alexandre Detiste  2015-12-31 
11:41:38 CET ---
Whoops wrong file: 

https://github.com/a-detiste/fedora/blob/763b90e0e05a0f1a07da5829579b57acf96642ff/game-data-packager-44-0.2.git2015123150f64b6.src.rpm?raw=true

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #11 from Hans de Goede  2015-12-30 
19:41:25 CET ---
(In reply to comment #10)
> I moved the manpage installation in the upstream shared 'make install' rule.

Good, can you please provide a srpm with the latest state of things for review?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #10 from Alexandre Detiste  2015-12-30 
07:04:57 CET ---
I moved the manpage installation in the upstream shared 'make install' rule.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #4 from Alexandre Detiste  2015-12-29 
09:48:57 CET ---
>1) You mix Recommends and Suggests, according to:
>
>https://fedoraproject.org/wiki/PackagingDrafts/WeakDependencies
>
>Suggests are pretty much ignored under Fedora atm. So you may want to change
>most Suggests into Recommends, at least for those Suggests which are available
>as Fedora packages in the standard Fedora repos.

The suggests vs recommends were carefully picked.

Suggests does the same thing on Debian (ie: about nothing but preventing
auto-removals and show this info in management UI's & packages website).

Some uncommon extractor is only needed for the Japanese demo of one game out of
200 for example.

'unzip' is only needed to patch Wolf3D 1.0 to Wolf3D 1.2 for example;
the newer zip archives are processed with native Python modules.

The tool has extensive runtime checking for missing tools and will
print out appropriate command needed to install missing tools.

See at the end of build.py:

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/game_data_packager/build.py#n2678


In the future we'd need to add suggests for 'steam', 'steamcmd'
& 'xdelta' and maybe even more.



steamcmd is a pain to make working, so you may want to copy this script:

http://anonscm.debian.org/cgit/pkg-games/steamcmd.git/tree/debian/scripts/steamcmd


> 3) The "%clean" section is obsolete, and also it is not intended to do a "make
> clean" but to remove the $RPM_BUILD_ROOT aka the "make install" DESTDIR.
Ok

> 2) The %install section is quite long, you say that you've added a "make
> install" target upstream, it would be good to use this in the next version
>
> 4) I see no license files in the %files sections. 

Both of those will be fixed in the proper v44 release tarball;
the first cross-distro release. ... but I'm not responsible
for publishing the releases.

I can ask to release now if that doesn't conflict against other
project goals; like the half-done inclusion of Unreal & UT support
https://lists.debian.org/debian-devel/2015/12/msg00372.html .

Or if you prefer we can publish a git snapshot right away;
name it v44~rc1 or something.
(I'd prefer, but I don't know what that involves)

Greets

Alexandre

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #5 from Alexandre Detiste  2015-12-29 
10:17:29 CET ---
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

According to this pre-release could be:

game-data-packager-44-0.1

(there's no "%{alphatag}" here)

?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #8 from Hans de Goede  2015-12-29 14:47:12 
CET ---
Hi,

(In reply to comment #7)
> Ok let's do that.
> 
> I've pushed the changes to my GitHub mirror, not yet on Debian official 
> server.
> This way I can still do a "git push --force" there if I want
> & official repos stay at 06f1b80.
> 
> https://github.com/a-detiste/game-data-packager/commit/8ce9d169311966056883afad716de7719d3a3808
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12343148

Looks good, but it seems that you've not yet switched to using "make install",
instead of the diy install ?

Regards,

Hans

p.s.

Be careful with submitting scratch builds of rpmfusion pkgs to
koji.fedoraproject.org please, in this case it is ok since game-data-packager
itself is 100% FOSS and the nonfree deps are the problem, but pkgs containing
any nonfree files should NOT be submitted to koji.fedoraproject.org

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #9 from Hans de Goede  2015-12-29 14:49:21 
CET ---
Oh, my bad, I see that you did move to "make install", there just is quite a
bit of manual fixup to do afterwards.

The current:

https://github.com/a-detiste/game-data-packager/blob/master/tools/game-data-packager.spec

Looks good, I will try to do a full review of the pkg soon.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Hans de Goede  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||j.w.r.dego...@gmail.com
 Blocks|2   |3
 AssignedTo|rpmfusion-package-review@rp |j.w.r.dego...@gmail.com
   |mfusion.org |

--- Comment #3 from Hans de Goede  2015-12-27 13:07:17 
CET ---
Hi,

Sorry for being slow in reviewing this. It has been a bit busy lately, but I've
time now.

Overall the spec file looks good, a few remarks:

1) You mix Recommends and Suggests, according to:

https://fedoraproject.org/wiki/PackagingDrafts/WeakDependencies

Suggests are pretty much ignored under Fedora atm. So you may want to change
most Suggests into Recommends, at least for those Suggests which are available
as Fedora packages in the standard Fedora repos.

2) The %install section is quite long, you say that you've added a "make
install" target upstream, it would be good to use this in the next version

3) The "%clean" section is obsolete, and also it is not intended to do a "make
clean" but to remove the $RPM_BUILD_ROOT aka the "make install" DESTDIR.

4) I see no license files in the %files sections. I guess since this comes from
Debian that it relies on the shared versions of the GPL text used in Debian, in
Fedora we ship a single license file per package, it would be good if you could
add the GPLv2 txt to the upstream tarbal (typically called COPYING) and add a 
"%license COPYING" to the file-list for both the main and the
doom2-masterlevels packages.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #2 from Alexandre Detiste  2015-11-20 
10:46:03 CET ---
I added a 'make install' target to the upstream Makefile

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/commit/?id=0c625260d6712441e3a5ee67e2f38bcea384cf09

Handling of man-pages is maybe not optimal.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

--- Comment #1 from Alexandre Detiste  2015-11-20 
00:55:02 CET ---
SRPM:

https://github.com/a-detiste/fedora/raw/3fd6fd228dcdf175e372cd641c26a544f3f17b82/game-data-packager-43-1.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3863] Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

Alexandre Detiste  changed:

   What|Removed |Added

 Blocks||2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.