[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

MartinKG  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from MartinKG  ---
The import and build have been done correctly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|33  |

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

leigh scott  changed:

   What|Removed |Added

 Blocks|33  |

MartinKG  changed:

   What|Removed |Added

 Blocks||33

--- Comment #24 from MartinKG  2016-08-26 16:49:00 CEST ---
Package CVS request
==
Package Name: qmplay2 
Short Description: A Qt based media player, streamer and downloader 
Owners: martinkg
Branches: f24 f25 rawhide
InitialCC:
--
License tag: free

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #23 from MartinKG  2016-08-26 15:48:47 CEST ---
@Vasiliy,

Thanks for the review.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

MartinKG  changed:

   What|Removed |Added

 Blocks||33

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

MartinKG  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

Vasiliy Glazov  changed:

   What|Removed |Added

 Blocks|2   |4
 AssignedTo|rpmfusion-package-review@rp |vasc...@gmail.com
   |mfusion.org |

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #21 from Vasiliy Glazov  2016-08-26 14:53:09 
CEST ---
PACKAGE APPROVED FOR FREE REPO

http://rpmfusion.org/Contributors#Your_package_gets_approved

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #20 from Vasiliy Glazov  2016-08-26 14:52:43 
CEST ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v3 or later)", "Unknown or generated". 49 files have
 unknown license. Detailed output of licensecheck in /home/vascom
 /review-qmplay2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/mime,
 /usr/share/mime/packages
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/solid/actions(kf5-filesystem, plasma-workspace),
 /usr/share/solid(kf5-filesystem, plasma-workspace)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in qmplay2
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in qmplay2
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the 

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #19 from MartinKG  2016-08-25 16:06:06 CEST ---
could somebody please finish the review ?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #18 from MartinKG  2016-08-23 19:46:12 CEST ---
new rpm files:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.08.19-3.fc24.src.rpm

%changelog
* Tue Aug 23 2016 Martin Gansser  - 16.08.19-3
- Removed call to gzip manpage file and added
 %%{_mandir}/man1/%%{pname}.1 to %%files section
- Replaced %%{_datadir}/qmplay2 by mcro %%{_pkgdocdir}
- Removed installation folder for doc files
- Changed if condition for installing system libdir
- Used macro %%autosetup
- Dropped %%{pname}-debug-info.patch
- Used %%{_datadir}/%%{name} for lang files
- Switched build commmand to %%cmake
- spec file cleanup

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #17 from Vasiliy Glazov  2016-08-23 09:31:55 
CEST ---
Use cmake can be very simple:

mkdir %{_target_platform}

%build
pushd %{_target_platform}
%cmake ..
popd
%make_build -C %{_target_platform}

%install
%make_install -C %{_target_platform}

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #16 from Vasiliy Glazov  2016-08-23 09:08:45 
CEST ---
1. Drop Patch0 at all because not using compile_unix script.

2. Change %setup -q -n %{pname}-src-%{version} to
%autosetup -n %{pname}-src-%{version}

3. Change 
%{_qt5_qmake} \
QT_SUFFIX=-qt5 \
QMAKE_CFLAGS="%{optflags}" \
QMAKE_CXXFLAGS="%{optflags}" \
QMAKE_LFLAGS="%{optflags}"

to
%qmake_qt5

Also, as I see in README.md, for compile in Linux recommended use cmake. May be
change build section to %cmake approach and just use %make_install macro in
%install section?

4. Change 
%dir %{_datadir}/%{name}/
%dir %{_datadir}/%{name}/lang

to
%{_datadir}/%{name}

5. Change
%doc %{_datadir}/%{name}/AUTHORS
%doc %{_datadir}/%{name}/ChangeLog
%doc %{_datadir}/%{name}/README.md
%doc %{_datadir}/%{name}/TODO
%license %{_datadir}/%{name}/LICENSE

to
%doc AUTHORS ChangeLog README.md TODO
%license LICENSE

6. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

rc040...@freenet.de changed:

   What|Removed |Added

 CC||rc040...@freenet.de

--- Comment #15 from rc040...@freenet.de 2016-08-23 09:07:33 CEST ---
(In reply to comment #14)
> > 3. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*
> done

Did you? I still see 
...
gzip -f %{buildroot}%{_datadir}/man/man1/QMPlay2.1
...
%{_mandir}/man1/%{pname}.1.gz
in your spec.

Remove the call to gzip and add {_mandir}/man1/%{pname}.1 to %files.


Furthermore:
- AUTHORS, ChangeLog etc. are supposed to be installed into %{_pkgdocdir} and
not into %{_datadir}/%{name}

Either change the line, which is installing them to install into %{_pkgdocdir}
or remove this line and use
%doc AUTHORS ChangeLog ...

- Similar with %license.
Here 
%license LICENSE
would be sufficient.

- qmplay2-kde-integration installs a file to /usr/share/solid/actions, however
this directory is unowned (Also cf. comment#6 above).

- The way you are copying the libs into their final destination is "arguable".
I would write it this way:

-%if "%{_lib}" == "lib64"
-mv %{buildroot}/%{_prefix}/{lib,lib64}
+%if "%{_lib}" != "lib"
+mv %{buildroot}%{_prefix}/lib %{buildroot}%{_libdir}
 %endif

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #14 from MartinKG  2016-08-22 21:04:02 CEST ---
(In reply to comment #13)
> 1. Need correct build script to use fedora compile flags. It is best to use
> macro %qmake_qt5. May be not use compile_unix at all.
> 
> 2. If used Qt5 you must correct BuildRequires:
> For example change qt5-qtbase-devel to pkgconfig(Qt5) and remove
> pkgconfig(QtCore) because it is Qt4 requires.
> 
> 3. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*
done

new rpms:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS
/qmplay2-16.08.19-2.fc24.src.rpm

%changelog
* Mon Aug 22 2016 Martin Gansser  - 16.08.19-2
- Dropped build script compile_unix
- Changed qt5-qtbase-devel to pkgconfig(Qt5)
- Removed QT4 BR pkgconfig(QtCore)

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com

--- Comment #13 from Vasiliy Glazov  2016-08-22 09:39:58 
CEST ---
1. Need correct build script to use fedora compile flags. It is best to use
macro %qmake_qt5. May be not use compile_unix at all.

2. If used Qt5 you must correct BuildRequires:
For example change qt5-qtbase-devel to pkgconfig(Qt5) and remove
pkgconfig(QtCore) because it is Qt4 requires.

3. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #12 from MartinKG  2016-08-20 15:24:45 CEST ---
new rpm packages:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.08.19-1.fc24.src.rpm

%changelog
* Sat Aug 20 2016 Martin Gansser  - 16.08.19-1
- Update to 16.08.19

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #10 from MartinKG  2016-06-09 11:13:16 CEST ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.06.01-2.fc24.src.rpm

%changelog
* Thu Jun 09 2016 Martin Gansser  - 16.06.01-2
- Added %%check section for desktop file

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@gmail.com

--- Comment #9 from leigh scott  2016-06-09 10:34:19 
CEST ---
(In reply to comment #8)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.06.01-1.fc24.src.rpm
> 
> %changelog
> * Thu Jun 02 2016 Martin Gansser  - 16.06.01-1
> - Update to 16.06.01

You need to validate these files

%{_datadir}/applications/%{pname}*.desktop

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #7 from MartinKG  2016-05-06 21:33:39 CEST ---
(In reply to comment #6)
> Since fedora hasn't supported a kde4 desktop since f21, I'd suggest:
> 
> * drop -kde-integration subpkg (move the contents to the main pkg)
> 
done

> * drop Requires: kde-workspace
> 
done

> * move the files to where plasma5/kf5-solid can use them:
> /usr/share/solid/actions
> 
done

> * and co-own /usr/share/solid and /usr/share/solid/actions (with other
> packages), or add 
> Requires: kf5-filesystem
done

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.05.06-2.fc24.src.rpm

%changelog
* Fri May 06 2016 Martin Gansser  - 16.05.06-2
- Dropped subpkg kde-integration
- Dropped Requires: kde-workspace-devel
- Moved kde4 desktop file to where plasma5/kf5-solid can use them
- Added Requires kf5-filesystem

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

--- Comment #6 from Rex Dieter  2016-05-06 19:28:05 CEST 
---
Since fedora hasn't supported a kde4 desktop since f21, I'd suggest:

* drop -kde-integration subpkg (move the contents to the main pkg)

* drop Requires: kde-workspace

* move the files to where plasma5/kf5-solid can use them:
/usr/share/solid/actions

* and co-own /usr/share/solid and /usr/share/solid/actions (with other
packages), or add 
Requires: kf5-filesystem

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #5 from MartinKG  2016-05-06 19:20:27 CEST ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.05.06-1.fc24.src.rpm

%changelog
* Fri May 06 2016 Martin Gansser  - 16.05.06-1
- Update to 16.05.06

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #4 from MartinKG  2016-05-03 10:58:45 CEST ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.05.02-1.fc24.src.rpm

%changelog
* Tue May 03 2016 Martin Gansser  - 16.05.02-1
- Update to 16.05.02

rpmlint:

rpmlint /home/martin/rpmbuild/SRPMS/qmplay2-16.05.02-1.fc24.src.rpm
/home/martin/rpmbuild/RPMS/x86_64/qmplay2-16.05.02-1.fc24.x86_64.rpm
/home/martin/rpmbuild/RPMS/noarch/qmplay2-kde-integration-16.05.02-1.fc24.noarch.rpm
/home/martin/rpmbuild/RPMS/x86_64/qmplay2-devel-16.05.02-1.fc24.x86_64.rpm
/home/martin/rpmbuild/RPMS/x86_64/qmplay2-debuginfo-16.05.02-1.fc24.x86_64.rpm
qmplay2.src: W: spelling-error Summary(en_US) downloader -> downloaded, down
loader, down-loader
qmplay2.src: W: spelling-error %description -l en_US ffmpeg -> MPEG
qmplay2.src: W: spelling-error %description -l en_US libmodplug 
qmplay2.x86_64: W: spelling-error Summary(en_US) downloader -> downloaded, down
loader, down-loader
qmplay2.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG
qmplay2.x86_64: W: spelling-error %description -l en_US libmodplug 
qmplay2.x86_64: W: no-soname /usr/lib64/libqmplay2.so
qmplay2.x86_64: W: no-manual-page-for-binary QMPlay2
qmplay2-kde-integration.noarch: W: spelling-error Summary(en_US) subpackage ->
sub package, sub-package, package's
qmplay2-kde-integration.noarch: W: no-documentation
qmplay2-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 11 warnings.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #3 from MartinKG  2016-04-24 12:21:45 CEST ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.04.23-1.fc24.src.rpm

%changelog
* Sun Apr 24 2016 Martin Gansser  - 16.04.23-1
- Update to 16.04.23

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #2 from MartinKG  2016-03-25 12:12:34 CET ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.03.24-1.fc24.src.rpm

%changelog
* Fri Mar 25 2016 Martin Gansser  - 16.03.24-1
- Update to 16.03.24

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

--- Comment #1 from MartinKG  2016-03-12 09:33:29 CET ---

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.03.11-1.fc24.src.rpm

%changelog
* Sat Mar 12 2016 Martin Gansser  - 16.03.11-1
- Update to 16.03.11

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

MartinKG  changed:

   What|Removed |Added

URL||http://qt-apps.org/content/
   ||show.php/QMPlay2?content=15
   ||3339
 Blocks||2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.